I’m not the decision-maker here, but I think this is fair feedback. You’re definitely not dumb. addGrant could have an interpretation that there’s a side-effect or stateful change happening.
d
dry-elephant-14928
04/24/2023, 5:02 AM
@powerful-ambulance-37101 you are right this is not intuitive. this is on me picking add instead of something sane like setGrant.
in the next major version I do agree we should change it. if you are up for making a PR, I would welcome it.
Would suggest:
• marking addGrant as deprecated, so it warns
• have a field
grant
(or simply
set grant(...)
p
powerful-ambulance-37101
04/24/2023, 6:27 AM
I’d love to but for the upcoming three months I am absolutely swamped with work. If at the end of July this is still open I’ll very happily pick this up, though.