https://linen.dev logo
Join Slack
Powered by
I'd like to work on this open-contribution issue: ...
# community-contributors
r
I'd like to work on this open-contribution issue: github.com/lightdash/lightdash/issues/27742 Since this is the only one that looks open and hasn't been assigned to anyone to work on.
✅ 1
p
Thanks Rohit! Could you drop a quick comment over on the GitHub issue itself? GitHub only lets us assign folks who've commented on an issue, so once you've done that we'll get it assigned to you and you're good to get started 🙌
r
I’ve added a comment on the GitHub issue. Thanks!
Hey Tori, just following up on this - I've added my comment on the GitHub issue as requested. I’m still interested in taking this one up whenever it's ready to be assigned. Thanks!
Hi Tori! I raised the PR for the issue assigned to me which is github.com/lightdash/lightdash/pull/27946 Let me know if there are any changes or anything I need to do to make sure it gets merged. About the issue, I tested the expected behaviour, which is working as explained in the issue github.com/lightdash/lightdash/issues/27742
Hi Team, I can see my PR has some 3 workflows awaiting approval and 2 failing workflows I confirmed that build & start work fine in my fork but fail in the PR. In the PR, the file changes are fairly simple and don't look like the cause of the workflow failures. Can anyone tell me if I'm missing something here?
t
Hey @Rohit Khatri you're not missing anything, we had some issues with the workflow on our side yesterday. Good news is we shipped a fix to this issue, and we used your solution in this PR: #27751. Things got a bit messy on our side, so we created a separate PR for this - thank you so much for your contribution on this one! 🙌 ⚡
✅ 1
r
Great, I really appreciate it I'd love to keep contributing to Lightdash and take on more issues Looking forward to contributing more!
lightdash party parrot 1
🙌 1
thank you 1
Open in Slack
PreviousNext
Powered by