github.com/lightdash/lightdash/issues/25933 github.com/lightdash/lightdash/pull/25935 I made a follow-up issue and PR for the labeled dimension and autocompletion. Would someone review it?

👋 Thanks for your message - someone from the Lightdash support team will get back to you asap. Feel free to add any additional context to the thread here in the meantime (screenshots, app version if you're self-hosting etc.).

Hey Daisuke, thanks for taking the time to work on this contribution 🙌 I can pass this to the team for review once all of the PR checks are passing - could you review those PR's again?

@Tori Whaley I think these failures are coming from this being a fork PR rather than the code itself — fork PRs don’t seem to get secrets or write-scoped tokens, which would explain: - Build E2E Image — looks like it can’t push to the org’s ghcr package - Post Test Selection Comment — 403, seems the read-only token can’t comment - Deploy Preview — OKTETO_TOKEN appears to be missing - Cleanup test schemas — DB secrets look empty, so psql can’t connect (The E2E jobs seem to be SKIPPED just because Build E2E Image failed first.) The code-validating checks all pass (Build & Test, OpenAPI, SDK CSP, Snyk, Socket), so I don’t think it’s the diff — but I could be missing something. Might this need a maintainer to re-run with secrets? Happy to rebase or adjust anything if needed.

Hey again, you’re right, those failing checks are all fork-PR secrets, nothing in your diff. A maintainer needs to approve the workflow run so CI re-runs with secrets, and we’ll handle that. I’ve passed your PR's (#25933 / #25935) to the team for review - we'll get back to you as soon as we can 🙌

I've upvoted issue #25933 for you! This issue has been requested by 1 other user. I'll notify everyone here as soon as it's fixed.