Hi team :wave: I have a feature request about the...
# community-contributors
s
Hi team πŸ‘‹ I have a feature request about the global search (the search bar you open with Cmd/Ctrl + K) that I'd love to discuss! Currently the search starts once you type 3 or more characters. That works well for English. But in Japanese β€” and CJK languages (Chinese, Korean) in general β€” short words of just 1 or 2 characters are very common, and we often want to search for them (e.g. 売上 = "sales", 葨 = "table"). With the 3-character minimum, these can't be searched at all, which makes the search a bit hard to use for us. Would it be possible to start the search from 1 character when the query contains CJK characters (while keeping the 3-character minimum for the rest)? It would be my first time contributing, but I'd love to challenge myself with this one! If it sounds good to you, would you let me take this on? πŸ™ (I've actually given it a quick try in my own fork already, and it seems to work fine.) Of course, if that's tricky, please feel free to just treat this as a feature request! Thanks for considering!
βœ… 1
p
πŸ‘‹ Thanks for your message - someone from the Lightdash support team will get back to you asap. Feel free to add any additional context to the thread here in the meantime (screenshots, app version if you're self-hosting etc.).
j
Hey Shota πŸ‘‹ We aren't taking too many contributions lately, but if it's quick for you to put up a PR with the fix you already have in your fork we can take a look! Details about opening a PR here https://github.com/lightdash/lightdash?tab=contributing-ov-file#opening-a-pull-request I wrote up an issue with some details: https://github.com/lightdash/lightdash/issues/24286 Does that match with how you've implemented?
s
Thanks for writing up the issueπŸ™ Yes, that matches my implementation really well β€” detect CJK characters in the query and drop the minimum to 1, while keeping the 3-character minimum for everything else. I also applied the same change to the other places that share this minimum-length guard, so the behavior stays consistent. I'll explain the details in the PR. I'll read through the contributing guide and put one up soon.
Just opened the PR No rush at all, whenever you get a chance!πŸ™‡β€β™‚οΈ
j
thanks! we'll take a look
@s-tsuru Thanks, this looks good to me so far - I can test once the PR checks are succeeding. GitHub is blocking merge because commits must have verified signatures. Could you please amend/resubmit the commit with a verified GitHub signature?
s
Thanks for checking! πŸ™ I've amended the commit with a verified signature, so it should be good nowπŸ™‡β€β™‚οΈ