Hi Lightdash community! I'd like to contribute to ...
# community-contributors
y
Hi Lightdash community! I'd like to contribute to Lightdash. I tried to follow the contribution steps, but the Slack invite link in CONTRIBUTING.md was expired at the time — it was just fixed in a6c3b71. So I went ahead and created the issue and PR before joining here. Apologies for the out-of-order process. - Issue: https://github.com/lightdash/lightdash/issues/21142 - PR: https://github.com/lightdash/lightdash/pull/21143 It adds native PDF export for scheduled deliveries using the existing headless browser infrastructure —
page.pdf()
alongside the existing screenshot path. The PDF has selectable text, clickable links, and matches the dashboard layout exactly. Happy to discuss the approach or make any changes needed.
✅ 1
Here's a sample PDF output from the PR: Unlike the existing "image as PDF attachment" option (which wraps a screenshot in a PDF), this produces a true native PDF — text is selectable, links are clickable, and charts render at full browser quality.
p
Hi @Yasuhiro Arakaki, thanks for the contribution! Our engineering team will review it this week!
electric mint heart 1
y
I noticed the CI on my PR (#21143) has some failures due to permission issues (GHCR push denied, DB connection, etc.). These seem expected for fork-based PRs. Just wanted to confirm — is this the normal workflow for external contributions? I see most PRs come from the lightdash org directly. Should I do anything differently?
p
For the CI, the key point is that the Build/Test passes. In this PR, the e2e test workflows that failed are not critical
electric mint heart 1
y
I've opened #21457 for the PDF-only scheduled delivery format (issue #21444). This builds on #21438 and adds a standalone PDF format option — no image required.