Hi Team! <https://github.com/lightdash/lightdash/...
# feature-requests
d
Hi Team! https://github.com/lightdash/lightdash/pull/20315/changes I made a PR of Athena assume-role feature. Would you take a look of it?
p
👋 Thanks for your message - someone from the Lightdash support team will get back to you asap. Feel free to add any additional context to the thread here in the meantime (screenshots, app version if you're self-hosting etc.).
Hey Daisuke 👋 thanks for your contribution here. I will see if the team has capacity to review this next week.
🙏 1
Hey Daisuke! Just a quick update, your PR has been prioritized on the team's board. The team will pick it up for review in the next 1-2 weeks.
❤️ 1
d
Thanks a lot!
👍 1
i
@Daisuke Taniwaki (dtaniwaki) hey! PR has been merged, thanks for your contribution!
I noticed you have more PRs, are you currently self-hosting lightdash?
d
Thank you for merging the PR. Yes, i self-host lightdash with a branch including all my patches. Would you review the other PRs as well?
i
We are at capacity, so this might be a slow process. Are there any urgent or pressing fixes in there? I'll try to go through them and prioritize.
Also, we just launched the Athena integration. How are you finding it? Are there any issues with the integration?
d
@Irakli As I use dbt with Athena in my company, I waiting for the Athena integration feature and sometimes checked the Slack channel, then finally found it. I’m now replacing redash with lightdash, but it doesn’t have enough features, so sent several PRs. I picked up PRs of high priority and critical issues for me, maybe all the Athena users. • feat: introduce parameter labels ◦ The most important feature, which is not related to Athena, is the labeled parameter. This is very useful feature of redash because you don’t have to remember actual IDs to filter data with it. • perf(athena): use ListTableMetadataCommand instead of GetTableMetadataCommand ◦ It causes an N+1 problem by GetTableMetadataCommand if you have hundreds of tables, the Athena integration doesn’t work by rate limit. • feat(athena): allow multiple Athena databases in a single project ◦ Using multiple databases based on the dbt layers is very common in dbt with Athena. Without this feature, we need to have multiple projects to handle a single dbt project. I’m happy to discuss the approaches to tackle the issues above.