Hey! Just submitted PR #18688 adding period-over-p...
# community-contributors
s
Hey! Just submitted PR #18688 adding period-over-period comparison with support for rolling period comparisons. Includes full UI, backend SQL generation, and type-safe implementation. Would appreciate a review when you get a chance! 🚀 https://github.com/lightdash/lightdash/pull/18688
✅ 1
p
👋 Thanks for your message - someone from the Lightdash support team will get back to you asap. Feel free to add any additional context to the thread here in the meantime (screenshots, app version if you're self-hosting etc.).
j
Hey @Sai thanush Reddy Thanks so much for taking the time to work on this and submit the PR - we really appreciate community contributions like this! Just a heads up for future contributions: we have a contribution process outlined in our community guidelines that helps us manage incoming work. We typically tag issues that are open for community contribution, so it's best to check those out first and comment on an issue before diving into a PR. This way we can align on the approach upfront and make sure it fits with our roadmap. That said, we'll take a look at what you've built here. Appreciate your enthusiasm for improving Lightdash!
s
Got it, thanks! Will follow the proper process and check tagged issues first next time. Appreciate you reviewing this anyway! 👍
chopchop purple heart 1