set the channel description: https://github.com/airbnb/mvrx/

👋

i am currently updating our detekt version and setup 😄

I have a data class that looks like this:

data class FeaturedState(
        val hospitalData: HospitalsViewModel = HospitalsViewModel(),
        val dealsData: DealsViewModel = DealsViewModel(),
        val marketingType: MarketingType = MarketingType.generalHealth
) : MvRxState

I’m attempting to morph both

hospitalData

and

dealsData

on two separate api calls. However when I try to change the value of

dealsData

, I receive this error:

Change parameter hospitalData type primary constructor class of class FeaturedState to DealsViewModel

Not sure what I’m doing wrong that it’s trying to set it on hospitalData instead of dealsData. Here is the function that runs the API calls: https://hatebin.com/owjqvhydaz

Maybe not about mvrx,but what is a future of epoxy?

This might be a dumb question, but I’m just curious about what’s considered best practice. I have a fragment that is supposed to display a QR code. It first queries a server for a token-string, generates a bitmap from the response, and then displays it in a view. Caveat is that drawing the bitmap from an input string takes about a second or two. My question is thus, what’s appropriate to store in the state? I’m thinking of just storing the tokenString in the state and having an asyncSubscribe to begin drawing the bitmap on success, but I could see how this impacts the ability to perform unit tests. I could also store the bitmap in the state, but that feels very heavy for the state.

data class FooBarState(
    val token: Async<String> = Uninitialized
) : MvRxState

in Mavericks, how to pass action from viewModel to fragment that call is successful take user to next screen ? I think that state is only for the data, how to pass the action. ?

Curious if Mavericks has any code coverage numbers for the library core code?

Are there any open source Android apps using Mavericks I could look at to better understand how it's used?

fwiw I'm working on an app that uses Jetpack Navigation with a single activity. I've looked at the simple examples AirBnb has in the Mavericks repo, and a few Medium articles, but I'd really like to see how others are using it in a full-on app.

@Ryan Brooks I apologize for @-ing you, but I suspect if there's anyone here who can point me in the right direction it would be you.

I haven't worked with RxJava, or with other MVI frameworks, and very little with Android architecture components, so there's still a bit of learning curve for me with this.

@gpeal please forgive my @-ing, but I feel like you probably can help. Any good Mavericks open source projects out there?

The Lottie ones are too. Maybe it'll be helpful to walk through a specific issue you're having?

Hey folks! I want to assisted inject the ViewModel using Hilt with more parameters along with the initial state. Is this provided by the framework? I can't really see a way to achieve this out of the box. This is what I want to achieve:

class MemesViewModel @AssistedInject constructor(
    @Assisted initialState: MemesState,
    @Assisted viewRenderer: MemesViewRenderer,
    @Assisted sideEffectHandler: MemesSideEffectHandler,
    private val repository: MemesRepository,
    private val dispatcherProvider: DispatcherProvider
) : MavericksViewModel<MemesState>(initialState) {
    ...
}

I'm using Jetpack Navigation with a single activity and fragments. If I need to navigate to another screen based on a property in MavericksState, should I call

navigate()

from within

invalidate()

in the fragment, or within

onEach()

in the view model?

Like, what's the best practice?

Or is having a state property determine if I need to navigate away the wrong approach altogether?

If I'm registering an

OnSharedPreferenceChangeListener

in a

MavericksViewModel

, what is the correct way to unregister that listener? Or should the registering/unregistering be done from the fragment/`MavericksView`?