https://kotlinlang.org logo
Join Slack
Powered by
# koin-contributors
  • p

    Pedro Francisco de Sousa Neto

    02/26/2024, 1:01 PM
    I couldn't start this task, but @Gustavo Barbosa Barreto will do it! ;)
    g
    a
    • 3
    • 6
  • p

    Pedro Francisco de Sousa Neto

    02/26/2024, 1:19 PM
    [PT-BR] Publiquei um novo artigo "Conhecendo o Koin Annotations" https://dev.to/pedrofsn/conhecendo-o-koin-annotations-5d45 [ENG] Comming soon ๐Ÿ™‚
    brazil 3
  • p

    Pedro Francisco de Sousa Neto

    02/26/2024, 2:24 PM
    What is missing to functions
    lazyModules()
    and
    waitAllStartJobs()
    drops the
    @KoinExperimentalAPI
    and becomes stable?
    a
    • 2
    • 3
  • p

    Pedro Francisco de Sousa Neto

    02/27/2024, 8:35 PM
    I know, what I'll ask is weird, but there is some way to avoid Koin compile safety fails in compile time because of non-annotated dependencies? I'm bypassing like this:
    Copy code
    @Module
    @ComponentScan("<http://br.com.custom.secret.app|br.com.custom.secret.app>")
    class MyModule {
    
        @Factory
        fun getNonKoinAnnotatedAppLog(): AppLog {
            return GlobalContext.get().get<AppLog>()
        }
    
        @Factory
        fun getNonKoinAnnotatedGson(): Gson {
            return GlobalContext.get().get<Gson>()
        }
    
    }
    u
    a
    • 3
    • 3
  • a

    arnaud.giuliani

    03/01/2024, 8:19 AM
    A proposed of flatten modules function PR : https://github.com/InsertKoinIO/koin/pull/1801
    ๐Ÿ‘€ 1
    ๐Ÿ‘ 1
    l
    m
    • 3
    • 7
  • a

    arnaud.giuliani

    03/05/2024, 3:05 PM
    Hello all, I'm working on Koin 3.5.4 - First RC1 is out https://github.com/InsertKoinIO/koin/releases/tag/3.5.4-RC1
  • a

    arnaud.giuliani

    03/05/2024, 3:06 PM
    I'm interested to have you feedback on this version, testing anything i working in version 3.5.4-RC1 I need to be sure that on ViewModel API, there is no breakings: https://github.com/InsertKoinIO/koin/pull/1809
  • a

    arnaud.giuliani

    03/05/2024, 3:06 PM
    The previous API has been too open, and could allow from inject in Activity/Fragment scopes .... which leads to memory leaks. I have introduce ViewModel scope then and ViewModel are created regarding the standard Android API, and Koin root scope
  • m

    Md Sadique Inam

    03/12/2024, 1:53 PM
    Is there any scope for koin-annotation for wasm
    a
    • 2
    • 1
  • t

    Thad

    03/27/2024, 6:07 PM
    So I created a bugfix PR but the macos builds are failing even though I didnโ€™t touch them, the changes were all in the android packages. Is there something Iโ€™m missing that would explain the failure?
    a
    • 2
    • 1
  • k

    Konstantin

    04/22/2024, 2:57 PM
    Hi folks, I'm new to using Koin. So I've pocked around the source code a bit and found some places I'd like to change. What's the best flow to discuss whether it should be done at all and to gain more context on why it was done this way in the first place? To create an issue and discuss questions there, or to create pull request and discuss there? Changes I'd like to propose mostly concentrate in
    InstanceFactory
    and code around it, specifically: 1. Changing upper type of generic T in
    InstanceFactory
    to
    Any
    - this prevents module definitions from returning null, especially when
    SingleInstanceFactory
    already uses null to check whether it was initialized; 2. Changing synchronization in
    SingleInstanceFactory
    and
    SingleInstanceFactory
    -
    get
    and
    drop
    aren't covered by synchronization, so theoretically race condition can happen; 3.
    ScopedInstanceFactory::dropAll
    does not call onClose callback, is this an intended behavior? 4. Remove
    isCreated
    method from
    InstanceFactory
    - it's really has to be used only in tests (it's not as common behavior of inheriting classes) and we can easily remove it; 5. Inline
    KoinPlatformTools::synchronized
    at least inside common module it can be inlined; 6. Add synchronization to `get`/`getOrNull` methods of native:`MutableGlobalContext` and jvm:`GlobalContext` .
    a
    • 2
    • 7
  • a

    arnaud.giuliani

    04/29/2024, 8:48 AM
    I will push some raodmap updates here. Just checking format/tool to help track and open topic for contribution
    koin parrot 4
  • j

    Junsu Park

    08/16/2024, 5:41 AM
    Hello, I've created PRs about editing docs. 1. added author docs 2. capitalized first character in docs It's been a while since I created the PRs. I found the process of PR lately. thank you
  • a

    arnaud.giuliani

    09/17/2024, 12:52 PM
    Your PRs have been merged
    ๐Ÿ‘ 1
    f
    • 2
    • 3
  • s

    Santiago Mattiauda

    10/01/2024, 12:16 AM
    Hello everyone! Iโ€™ve been reviewing koin-androidx-startup, and I think itโ€™s great that theyโ€™ve included support for Android Startup. I know itโ€™s their first version, but Iโ€™ve left an issue with some improvement suggestions here. I appreciate your feedback.
    a
    • 2
    • 4
  • v

    Vladislav Yaroshchuk

    10/15/2024, 3:02 PM
    Hi folks! Iโ€™ve opened my first PR to Koin PR: https://github.com/InsertKoinIO/koin/pull/2020 GH Disussion: https://github.com/InsertKoinIO/koin/discussions/1507 Issue: https://github.com/InsertKoinIO/koin/issues/1510 Message in #C67HDJZ2N I sent by mistake: https://kotlinlang.slack.com/archives/C67HDJZ2N/p1728671967689479 (just to connect threads)
    ๐Ÿ™Œ 4
  • a

    arnaud.giuliani

    11/15/2024, 9:03 AM
    Enqueueing content for 4.0.1 right now loading
    ๐Ÿ™Œ๐Ÿพ 1
    ๐Ÿ™Œ 5
    ๐Ÿ™Œ๐Ÿฝ 1
    h
    • 2
    • 4
  • a

    Adam Jarvis

    11/18/2024, 10:02 AM
    I was looking at implementing the
    @PostConstruct
    and
    @PostDestroy
    from JSR-330 for koin Would this method in the
    abstract InstanceFactory
    be the right place? I was planning on looking on the instance's class for the relevant annotated methods, and then invoking the
    @PostConstruct
    immediately after a non error invocation of
    create
    And then inside the
    drop
    method, invoke the
    @PostDestroy
    method Is this the right approach?
    ๐Ÿ‘€ 1
    โœ… 1
    a
    • 2
    • 4
  • a

    Adam Jarvis

    01/02/2025, 7:28 PM
    Hey @arnaud.giuliani ๐Ÿ‘‹ happy new year! I've made a small PR to solve this issue, which I also encountered on my own project using KSP2. I've published to my maven local and this fixes the bug the issue raised Think we could have it in the
    2.0.0
    release?
    a
    • 2
    • 15
  • a

    Adam Jarvis

    01/06/2025, 9:45 AM
    I'm working on an implementation of a Junit5 ParameterResolver that will enable injecting of koin-managed instances into tests, similar to how koin manages injection elsewhere For example:
    Copy code
    @ExtendsWith(ThisNewKoinExtension::class)
    class MyIntegrationTest(
    	val someService: Service,
    	val someRepository: SomeRepositoryInterface
    ) {
    	// tests as usual
    }
    I have the bootstraps of it working well. Working on some tests for it now @arnaud.giuliani this something you're open to including? I'd prefer to keep it separate to the existing ParameterResolver we have, as that overloads the start/stoping of koin
    a
    • 2
    • 5
  • a

    arnaud.giuliani

    01/06/2025, 5:16 PM
    set the channel topic: Contributing together to Koin with KFIP - https://github.com/InsertKoinIO/KFIP/
  • a

    arnaud.giuliani

    01/06/2025, 5:22 PM
    Hello all, I've opened Koin KFIP repository to open new features and improvement process for Koin. Next features/big improvements will go through this. This chat is the perfect place if you are interested โœŒ๏ธ
    ๐Ÿ‘ 1
    koinscroll 1
  • a

    arnaud.giuliani

    01/10/2025, 5:33 PM
    Proposing an alternative to
    KoinApplication
    compose function, with
    KoinMultiplatformApplication
    to handle automatic context & logger for every platform (especially for Android). No need anymore to have a specific config for android with
    androidContext
    &
    androidLogger
    https://github.com/InsertKoinIO/koin/pull/2114 (for those who want to give feedback)
    ๐Ÿ‘ 2
    ๐ŸŽ‰ 1
  • a

    arnaud.giuliani

    01/10/2025, 5:36 PM
    I'm preparing also a KFIP proposal for Set/Map values injection, following up https://github.com/InsertKoinIO/koin/pull/1951
  • a

    arnaud.giuliani

    01/16/2025, 5:07 PM
    Currently unqueueing all issues about Koin Annotations 2.0. Will work on it over next week
  • s

    skyecodes

    01/20/2025, 3:49 PM
    Hey, I just opened a new PR that fixes an issue on the new custom qualifier annotations feature that I've added (which was released in 2.0.0-Beta3): #211 Since from my point of view it is more of a fix than a new feature I assumed I could directly open a PR.
    a
    • 2
    • 1
  • a

    arnaud.giuliani

    02/28/2025, 7:45 AM
    Hello ๐Ÿ‘‹ I'm testing a Koin patch to solve Compose context initialization. There was previously an issue with Confetti's wear tests and some Compose UI tests. I've tested locally and this patch is working. I would like some checks from someone else, to help me confirm that this compose context initialization is now ok. The test is to use Koin
    4.0.3-Beta1
    - You can even remove
    KoinAndroidContext
    or
    KoinContext
    from your App. https://github.com/InsertKoinIO/koin/pull/2138
  • a

    arnaud.giuliani

    03/06/2025, 10:48 AM
    I may look at contributors, to help add "standard" annotation to Koin, in 2.1. If some of you already contributed, and interested to continue ๐Ÿ‘€
    a
    • 2
    • 2
  • a

    Adam Jarvis

    03/08/2025, 2:48 PM
    @arnaud.giuliani noticed an edge case bug with generating nested class type bindings
    Copy code
    interface Foo {
    	
    	@Single
    	class Bar : Foo {
    	
    	}
    }
    Results in:
    Copy code
    single() { _ -> org.koin.example.Bar() } bind(org.koin.example.Foo::class)
    But the correct format would be:
    Copy code
    single() { _ -> org.koin.example.Foo.Bar() } bind(org.koin.example.Foo::class)
    Note the parent class in the fully qualified path for the constructor
    a
    • 2
    • 1
  • a

    arnaud.giuliani

    05/12/2025, 5:01 PM
    After Compose 1.8 integration, Ktor 3.2 DI Integration work is landing Koin / Ktor DI integration is ready - https://github.com/InsertKoinIO/koin/pull/2196 It's working on the workshop - https://github.com/arnaudgiuliani/ktor-workshop-2025/commit/8d73ab7c03c816a1b5ce2e42feed8380f6e0ae41
    koinscroll 5