My first PR for infisical :grin: It implements an...
# infisical-contributing
g
My first PR for infisical 😁 It implements an improvement to the CLI that I’ve wanted for ages - the ability to configure and use the infisical API URL in `.infiscal.json`I’m eagerly looking forward to any feedback.
a
I like this! Thank you for the contribution. I'll review it soon
🙇 1
g
Hi @Akhil Mohan - just a gentle nudge about reviewing the PR. I’ve updated it to the latest
main
and there’s now a GitGuardian failure that came through with that pull. Not sure if there’s anything I can do re: that?
Hi @Akhil Mohan - checking in here - have you had a chance to look at the PR yet? I’m keeping it up to date with main in the meantime.
Hi @Akhil Mohan and/or @Saif Rahman - is there any chance I could get a review on this PR? Or get someone from Infisical to trigger the claude-bot review? I’ve been keeping the branch up to date with
main
, but there still appears to be a gitguardian failure from a commit on
main
that isn’t part of my changeset.
m
Hi @Gabriel Fortuna, we'll be sure to merge this in before end of week. Sorry for the long wait
g
hi @Maidul Islam - thanks for the reply. In the meantime, can someone initiate the claude bot review?
@Maidul Islam - no problem. I see that another infisical dev has made their own PR to implement the feature with some differences to mine… I’m closing my PR, and will follow the new one https://github.com/Infisical/cli/pull/256
m
Yes, you can follow the new one
🙌 1