This message was deleted.
# hamilton-helps
Slackbot
12/13/2022, 11:04 PMThis message was deleted.
👀 1
s
Stefan Krawczyk
12/13/2022, 11:06 PMcan you try flipping the order of the decorators:
Copy code
@extract_columns('prompt', 'seed')
@does(_cross_join)
def prompt_seed_cross_join(sample_field1: pd.Series, sample_field2:pd.Series) -> pd.DataFrame:b
Baldo Faieta
12/13/2022, 11:08 PMflipping the order of the decorators doesn't change the result. Same error
🤔 1
s
Stefan Krawczyk
12/13/2022, 11:09 PMsounds like a 🐛 then. Let me recreate the issue locally.
b
Baldo Faieta
12/13/2022, 11:09 PMthanks for looking into it
s
Stefan Krawczyk
12/13/2022, 11:13 PMokay confirmed I can recreate it.
Stefan Krawczyk
12/13/2022, 11:27 PMokay I think I found the issue; we aren’t propagating the type.
b
Baldo Faieta
12/13/2022, 11:29 PMI guess I'll wait for a patch then
s
Stefan Krawczyk
12/14/2022, 12:30 AMyep — will create an issue for it shortly; don’t think it should be a hard fix. Thanks for finding it 🙂
Stefan Krawczyk
12/14/2022, 4:38 AM@Baldo Faieta https://github.com/stitchfix/hamilton/issues/244
Stefan Krawczyk
12/14/2022, 8:38 AM@Baldo Faieta I believe I have a fix here — https://github.com/stitchfix/hamilton/pull/245 if you have time I’d love for you to verify it.
Stefan Krawczyk
12/14/2022, 6:39 PM@Baldo Faieta you should be able to try out the fix by installing Hamilton from the branch with the fix:
Copy code
pip install <git+ssh://git@github.com/stitchfix/hamilton.git@fix_does>Stefan Krawczyk
12/14/2022, 6:39 PMCould you do that to verify it please?
b
Baldo Faieta
12/15/2022, 5:53 PM@Stefan Krawczyk I'll try it and let you know
👍 1
Baldo Faieta
12/15/2022, 10:47 PM@Stefan Krawczyk I tried it and it works! Also, it is agnostic to the order of the decorators which is nice. Thank you for you fast turn around
👍 1
s
Stefan Krawczyk
12/15/2022, 11:39 PM@Baldo Faieta great! You’re welcome. I’ll work on getting a new release out with @Elijah Ben Izzy to push the fix.
2 Views