https://github.com/stitchfix/hamilton logo
Join Slack
Powered by
Hey guys, do we have periodic CI jobs that install...
# contribute
i
Hey guys, do we have periodic CI jobs that install the latest (allowed) versions of dependencies and ensure CI is green? Asking because I created a couple of PRs today and they failed on preëxisting issues (mostly deprecation warnings). Related to that, there's a prek github action we can use instead of calling it manually
s
we don't but that's a good idea. most of our issues are other libraries changing deps
i
Ok, I'll dispatch an agent to minimally copy airflow's mechanism
Can we create an #internal-ci-cd channel with a slack token to go with it and add that to the project's github secrets?
🙌 1
👍 1
Hi Stefan! Did you get a chance to create a slack token for #C0C49AHDW69 and add it to GitHub? If so, can you please tell me the envvar name so I can include it in the ci configs?
s
links to what I need to do / what key words to prompt for?
you want a token to be able to hit slack channel right?
i
yeah it should be a webhook for a particular channel
s
SLACK_WEBHOOK_URL is the secret
So you should be able to add something like:
Copy code
- name: Notify Slack on failure
   if: ${{ failure() && github.event_name == 'schedule' }}
   uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
   with:
     webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
     webhook-type: incoming-webhook
     payload: |
       text: >-
         Hamilton latest-dependency CI failed:
         ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
👍 1
i
There will be a followup PR to add a python dependabot and uv.lock
cc @Jernj Frank
j
Sorry, missed this. @Iliya R, approved and merged!
gratitude thank you 1
i
Do any of you know how to do
Run Unit Tests by hand on main with notify-slack on, and check the test message lands in the channel. Pull-request runs get no secrets and schedules run only from the default branch, so this is the first time the webhook itself is exercised.
j
I thought you put a dispatch in the yaml file, if you go under actions, do you not see it there to manually trigger it? Or does a maintainer need to do it because of permission issues?
i
I don't even know where to look; it's likely maintainer-only
This is what I have under actions:
s
🤔 not sure I see the new code under workflows?
j
I think I found it:
👍 1
So you go under 
Actions
tab and on the left under 
Workflows
you have to select 
Unit Tests
Would be good to know if you can run this as well @Iliya R. I just triggered one run
i
And how do you set notify-slack?
Note in my screenshot there's no giant green button
j
Ah, yes. So only maintainers can run it
you wanna join the PPMC fun @Iliya R? Then you get the green button
i
I wouldn't mind... But like I told Stefan in the past, I'm worried that my knowledge of Hamilton is too superficial :|
Also I think there's a "committer" stage before PPMC
j
I thought so too before I agreed.. But you just play your strengths and do what you are comfortable doing and ping/tag somebody else when unsure. It's a somewhat large codebase, so I don't think anybody expects anybody to know everything. I thought you already had the "commiter" status?
👍 1
i
I'm a "collaborator" aka "triage team" - my permissions include opening/closing issues/prs, and modifying issue/pr metadata (assignees, reviewers, tags, ...)
Open in Slack
PreviousNext
Powered by