https://github.com/stitchfix/hamilton logo
Join Slack
Powered by
<@U03AV0GG20H> Several notes after trying to follo...
# contribute
i
@Stefan Krawczyk Several notes after trying to follow https://github.com/apache/hamilton/tree/main/scripts#verification-script: 1. How do deal with this?
Copy code
$ gpg --verify apache-hamilton-1.90.0-incubating-src.tar.gz.asc apache-hamilton-1.90.0-incubating-src.tar.gz
gpg: Signature made Sat 04 Apr 2026 08:10:01 IDT
gpg:                using RSA key FE668E857E89A11C5E5C000CA8D3D15600545C61
gpg: Good signature from "Stefan Krawczyk (1 year key for Hamilton project) <stefank@cs.stanford.edu>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: FE66 8E85 7E89 A11C 5E5C  000C A8D3 D156 0054 5C61
2. incorrect arg name to uv
Copy code
$ uv venv --python 3.11 --clean
error: unexpected argument '--clean' found

  tip: a similar argument exists: '--clear'
3. re 
scripts/verify_apache_artifacts.py
docstring - IMHO we should set it up to work as 
uv run verify-... <args> <kwargs>
and do the mapping to the actual repo scripts internally
I suspect the SVN path is incorrect - should be 
.../incubator/apache-hamilton/1.90.0-RC0/
instead of 
../incubator/hamilton/apache-hamilton/1.90.0-RC0/
Core unit tests:
Copy code
FAILED tests/cli/test_logic.py::test_git_directory_exists - OSError: fatal: not a git repository (or any of the parent directories): .git
test_git_directory_exists()
is integration-style and currently depends on the checkout being a real Git worktree.
I'm changing it to unit-test 
get_git_base_directory()
by mocking 
subprocess.run
, which makes it stable under uv run tarball/sdist environments.
Will submit a PR shortly
Plugin tests:
Copy code
apache_hamilton-1.90.0$ uv run --active pytest plugin_tests/ -x -q
Fatal Python error: Illegal instruction
...not sure what's up with that
s
```$ gpg --verify apache-hamilton-1.90.0-incubating-src.tar.gz.asc apache-hamilton-1.90.0-incubating-src.tar.gz
gpg: Signature made Sat 04 Apr 2026 081001 IDT
gpg: using RSA key FE668E857E89A11C5E5C000CA8D3D15600545C61
gpg: Good signature from "Stefan Krawczyk (1 year key for Hamilton project) <stefank@cs.stanford.edu>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: FE66 8E85 7E89 A11C 5E5C 000C A8D3 D156 0054 5C61```
is normal AFAICT
incorrect arg name to uv
doh
I suspect the SVN path is incorrect - should be 
.../incubator/apache-hamilton/1.90.0-RC0/
instead of 
../incubator/hamilton/apache-hamilton/1.90.0-RC0/
yeah my bad -- I did add a note to the vote about that
Copy code
FAILED tests/cli/test_logic.py::test_git_directory_exists - OSError: fatal: not a git repository (or any of the parent directories): .git
🙏
Plugin tests:
```apache_hamilton-1.90.0$ uv run --active pytest plugin_tests/ -x -q
Fatal Python error: Illegal instruction```
...not sure what's up with that
weird
i
I have the fix on a side branch
For the git thing
👍 1
2 Views
Open in Slack
PreviousNext
Powered by