<@U03AV0GG20H> <@U03AGP3AFM5> Hi guys! Is it ok th...
# contribute
k
@Stefan Krawczyk @Elijah Ben Izzy Hi guys! Is it ok that I created a draft PR about integrations with AWS so I can continue working on it? If not, I can just remove it and recreate it after it is ready. The PR: https://github.com/DAGWorks-Inc/hamilton/pull/768
👀 2
🔥 2
👍 1
s
this is a great first pass.
looks good — draft state is fine.
I’m excited for it!
🙏 1
and otherwise this commit seems pretty standalone — I would only add a reference to it / mirror the docs for it on this page too.
e
Nice work! This is really cool.
🙏 1
s
@Konstantin Tyapochkin BTW sagemaker connection/story would be helpful. I’ve been asked about it: “how do I go from Hamilton to running on sagemaker?”
k
Ok, I thought I would first prepare an example for Glue, but it actually doesn’t matter to me; I can do that for SageMaker. It has its own job processing environment with arbitrary code in a Docker container: https://docs.aws.amazon.com/sagemaker/latest/dg/build-your-own-processing-container.html So, I’ll prepare the example for SageMaker, and then we’ll decide if it is useful to have anything for that in the plugin format. Sorry, I’m moving on very slowly; I hope I’ll be able to devote more time to that in the next few days.
👍 1
I finished with the AWS examples. I suppose these three examples for SageMaker, Lambda, and Glue could be enough. I’ll try to join the office hours on Tuesday to discuss whether we need any additional plugins. Or we can arrange a separate call for that.
👍 1
s
Awesome. Will take a look. If we merge today/tomorrow we can publicize it with this week’s release.
👍 1
Looks good @Konstantin Tyapochkin. Let’s merge and do follow up PRs as needed, sound good? Can chat on Tuesday regarding plugins :)
👍 1
k
Ok, great!
👍 1