This message was deleted.
# hamilton-helps
Slackbot
04/18/2023, 7:17 PMThis message was deleted.
e
Elijah Ben Izzy
04/18/2023, 7:27 PMArghh! I was hoping no one would run into this. Its definitely a weird case of wanting to inject the same thing twice… Has to do with the internals.
I can probably scope out a fix pretty easily, but curious as to why you’d want to do this (one of the reasons I haven’t fixed it yet is cause I’m not convinced having the same input twice in a parameterize function is actually worth it…)
a
Ankush Kundaliya
04/18/2023, 7:31 PMI am trying to add multiple columns to a dataframe which have same logic of fill but different column names
e
Elijah Ben Izzy
04/18/2023, 7:32 PMGot it — yeah, definitely think that’s valid. Let me work on a fix — do you have a workaround for now or are you blocked?
a
Ankush Kundaliya
04/18/2023, 7:34 PMNo, not blocked. I can have a temporary fix for this and continue on rest!
e
Elijah Ben Izzy
04/18/2023, 7:35 PMGreat! Gonna take a quick stab at this shortly anyway — hopefully it’s as easy as i think. Will ping you back when I have a test release for you to try out
👍 1
Elijah Ben Izzy
04/18/2023, 7:59 PMFYI here’s the TODO in the code about this 😆 https://github.com/DAGWorks-Inc/hamilton/blob/323c4ea352d053faea11c834d1747451096f5ea5/hamilton/function_modifiers/expanders.py#L200
Elijah Ben Izzy
04/18/2023, 8:59 PM@Ankush Kundaliya I think this should do the trick: https://github.com/DAGWorks-Inc/hamilton/pull/142
pip install git+<https://github.com/dagworks-inc/hamilton.git@fix-parameterize-repeated-sources>a
Ankush Kundaliya
04/19/2023, 11:44 AM@Elijah Ben Izzy It’s working! Thanks 😊
e
Elijah Ben Izzy
04/19/2023, 3:51 PMExcellent! I’ll push the release today. Thanks for finding the bug!