https://www.growthbook.io/ logo
Join Slack
Powered by
This message was deleted.
# ask-questions
w
This message was deleted.
f
hi Emmanuel
let me take a look at the code
🙌 1
for 1, you are correct. I can make a PR for the 'lost' state, but I'm not sure we can draw conclusions about which variation to 'force' if an experiment is 'did not finish' or 'inconclusive'
for 2, I'll make a pull request for that too- its a simple change and not sure why we only want to return it for running experiments.
we should be able to get these out tomorrow assuming @future-teacher-7046 agrees
s
Wow! That would be AWESOME it these 2 things are live tomorrow 🥰
f
s
You're fantastic guys!
f
For 1, the SDKs ignore experiments which are stopped and did not win. So it will always return variation 0 and 
inExperiment
= false in that case. We could have it explicitly force variation 0 to make that behavior more clear.
👍 1
s
Just reviewed your PR @fresh-football-47124. Available here. Tell me what you think.
f
replied
✅ 1
we merged it
146 Views
Open in Slack
PreviousNext
Powered by