Hi, I think I've configured everything properly, b...
# report-bugs
z
Hi, I think I've configured everything properly, but commit signing doesn't work for me. What I have done: • Generated key on Graphite Commit signing settings page for my primary (and only) Github email and added it to my account • Made the email public (verified by looking at my profile in incognito mode) • Turned off "Keep my email addresses private" But still, after Graphite rebases my PR, the commit becomes unverified (unsigned): > This commit is not signed, but one or more authors requires that any commit attributed to them is signed. Would appreciate some help to figure out what I did wrong. If helpful, I can provide the PR url and commit hash via DM
Extra context: it's a private repo, which doesn't use merge queue, but requires commits must have verified signatures before merging into trunk
c
You've got the right setup steps. After Graphite rebases server-side, the new commits need to be signed with your Graphite key and if you deleted/re-added the key, make sure GitHub has the current public key from *https://app.graphite.com/settings/commit-signing* (*https://graphite.com/docs/configure-signed-commits*). Can you link the PR URL you noticed this happening and I can investigate on our side?
z
yes I've double checked that Graphite had my GPG key. And FWIW, it worked for me weeks ago, but last week, it only worked occasionally. I will DM you a PR where it didn't work
c
Hey! Followed up in a PM but we were able to duplicate this and got it to the team for review. Can I verify if you are still seeing this issue? Thanks!
z
Thanks! It seems to work perfectly now 🙂
c
Woo! Great News! Let me know if anything else pops up. Thanks!
d
@Chris Bowie I'm running into this same issue.
c
This bug should be fixed for everyone, do you have a PR link where this happened?