We had an issue where checks on GitHub failed, but by the time they had, Graphite had already merged the PR, leaving our main branch in a broken state. How can I work out what allowed that to happen?

Thanks for flagging this. Could you send the Graphite PR URL and, if you have it, the name of the GitHub check that failed? With that, we can look at the PR’s merge history and compare what GitHub reported vs what Graphite saw at the time it merged.

Thanks Jordan https://app.graphite.com/github/pr/liveflow-io/accounting/5716 Three actions • Check openapi.json • Check sync fixtures are up to date • Run tests

Hey Evan - It looks like those three actions are set as 'optional', in[ which Graphite inherits from GitHub as a check not required to succeed to merge into main. To make these block future merges, add the exact check names to the required status checks in GitHub’s branch protection or ruleset for main.

my bad, there is also Backend CI Result which aggregates all checks, including these three. It is required, and it also failed in this run (it will fail if any of the individual checks fail)

Hi Evan, we're also showing (Backend CI Result) as optional. Could you please confirm by providing a screenshot of the aggregate check showing '*required*' ?

image.png

Thanks for the screenshot! This looks most likely related to a tracked bug where Graphite can incorrectly show required CI checks as optional in the PR UI. Could you also send a screenshot from the GitHub side for that same PR showing the required checks in context? That would help us attach this case to the ongoing investigation.

image.png,image.png

Hey Evan, thanks for the additional screenshots. I’ve attached this to the tracked issue on our side and will update you once engineering has concluded the investigation.

thanks Jordan