If the PR comment is made on the PR itself instead of on any of the files, I won't get notification on Graphite Slack app, nor it will appear in my Inbox on Graphite. https://app.graphite.com/github/pr/vialytics/flutter-app/2056/FLTR-2740-don't-pause-CA-on-permission-dialogs-(CaInterruptionCoordinator-refactor)

Hi there, that behavior is expected if you’re not the PR author and weren’t explicitly @mentioned. Graphite treats PR-body comments differently from file/line comments. For PR-body comments, Graphite only creates a notification for the PR author or anyone directly mentioned. Since Slack and the notification panel/Inbox depend on that notification being created first, there’s nothing for Slack or Inbox to show in that case. File/line threads notify prior participants, which is why those comments behave differently.

Thanks @Jordan Toomajon, but I am the PR's author

Thanks for clarifying! If you're the PR author, a PR-body comment from another user should create both a Graphite in-app notification and a Slack notification assuming your notification settings are enabled. The one exception is: Graphite intentionally suppresses notifications for self-actions. So if the PR author makes the comment themselves, or if someone comments on their own PR or thread, no bell or Slack notification is created. Could you send me one specific example where another user commented on the PR body and you, as the PR author, didn't receive a Slack message or an in-app bell notification? A PR link, the comment author's handle, and the approximate timestamp will let us check whether the notification was actually created and whether Slack delivery was attempted.

Hi Yin, I checked the

mtylman-vialytics

comment, and Graphite did create an in-app notification for it. It looks like it was hidden because “Hide read” was on. If you turn that off in the notifications view, it should show up. One clarification too: comment notifications show up in the bell/notification view and Slack, not reliably as a separate item in the PR Inbox. The Inbox is more of a PR queue and depends on your filters/read state, so the bell is the better place to track individual comments.

Thanks @Jordan Toomajon. It seems like it did show up in the Graphite in-app notification, but that's a place I never use -- if I'm already on Graphite website, I don't need the notification any more. The comment notification doesn't show up on Slack, and the comment count(if comment on a PR instead of a file) doesn't show up on right hand side of the PR items. I am not sure what you mean by "comment notification shows up as a separate item in the PR inbox". But I expect the comment count on each PR includes the comment on the PR itself too. Well, maybe you don't show it up there because this kind of comment cannot be resolved, but I still need to know they exist somehow.. At least Slack should work for this kind of comment..

Hi Yin, yes, that makes sense. Sorry for the confusion in my last message. I checked the Slack delivery for the

mtylman-vialytics

comment you sent earlier. Graphite did create the notification and attempted to send it to Slack, but that Slack send failed on our side before it reached you. So that part was not caused by your notification settings. The right-hand comment count is separate. Today that count is for review/file-thread comments, not top-level PR conversation comments, which is why the PR-level comment did not change that number. I agree that makes these comments easier to miss. Short version: the in-app notification was created, the Slack notification should have gone out but failed on our side, and PR-level comments currently do not show in that thread-count UI. I’ll flag both pieces internally.

Thanks @Jordan Toomajon