hi! recently we upgraded our CODEOWNERS (we have a...
# report-bugs
z
hi! recently we upgraded our CODEOWNERS (we have a rule requiring code owner approval), and this is correctly reflected on GitHub by allowing merge when changes do not touch files that have code owners. but on graphite merge is blocked saying code owner approval is required, showing someone as code owner but they're not (they used to be before the CODEOWNERS change).
✅ 1
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
z
fixed -- we had switched to
develop
as trunk branch but the merge queue was still configured with merge to
main
, and graphite seemed to be reading the codeowners on
main
for all PRs (even tho it should've read the codeowners on the trunk aka
develop
). we removed and remade a merge queue.
p
hey zhening. glad you were able to resolve your issue. yes this is expected behavior since you updated your github ruleset and switched your trunk branch to
develop
. under the hood, graphite doesn't automatically update the trunk branch in merge queue so removing and recreating to point to the correct trunk branch makes sense.
👍 1