hey Graphite team, one of our teammates discovered some unexpected behavior in Graphite this morning: he approved a PR for a repo for which he is not a CODEOWNER, but Graphite marked it as "Ready to merge". GitHub's PR page correctly shows the PR as blocked though. any ideas?

(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using

gt feedback --with-debug-context <any message>

• https://app.graphite.com/github/pr/noda-ai/nife/281 • confirmed twice by dismissing teammate's review (Graphite showed "Needs more approvals") then having him approve again (reverted back to "Ready to merge" again)

Hey Dan, are you using classic branch protection rules (BPRs) or rulesets for this?

hey Brett, we're using rulesets

2 more question for you here: 1- who saw "Ready to merge" in github? 2- does your codeowners change such that the approver was once a codeowner?

1. we both saw Ready to merge in Graphite but I never saw that message in GitHub 2. CODEOWNERS was last updated 3w ago, but yes, the approver from this morning used to be a CODEOWNER (by GitHub team association)

okay, so its seems that we had a stale understanding of CODEOWNER membership - versus a repo owner saw this because they could have potentially over-rode the requirement.

looks like the author tried merging from graphite a couple times since this morning's approval

right, that would make sense if it wasnt actually mergable in github that we would fail.

gotcha, any way we can refresh cache or trigger some sync/update from our side? we may be continuing to revise CODEOWNERS across several repos (albeit infrequently)

ill need to look into this and circle back

copy, thank you!