Hi, I'm piloting Graphite for the company I work f...
# report-bugs
d
Hi, I'm piloting Graphite for the company I work for TTD (S&P500). Unfortunately there has been no PR reviews triggered, although Graphite says that it's reviewed the code, but there are some pretty blatant issues, so I believe it didn't run at all
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
p
Hey Diego, thanks for the shout on this. You are correct in your analysis here, the logs seem to indicate LLM usage was exceeded and unfortunately in that case we fall back to "no error found". The limit resets hourly.
(from when usage started, not on the hour)
d
oh i see, I'm running a pilot for TTD my company, would it be possible to get extra credits just for these PRs?
p
At this time i cannot do that unfortunatelty
d
I've just tried this yet again, by opening new PRs and nothing happened, but there's no information about why it's not running?
We want to compare Graphite against all the other big AI code review players in the market, but if I don't have credits or a way to assess it, we will have to leave it out of the conversation, I've been trying for a while now and it just keeps silently failing? These are just 10 small PRs to pilot the quality of the code reviews, yet I've somehow exceeded my LLM usage?
cc: @Fernando Cho
new PR that just got opened, Graphite succeeded without leaving a PR review at all: https://github.com/ai-codereview-testing-ttd/teamhub-frontend-graphite/pull/16
p
I will reach out to Fernando, could you share a new PR link?
oh nice you read my mind thanks
did you change the Repos you have this enabled on? i see it only on 2 and the above does not look like either
d
I can see it there
p
ah i see, different org
d
I'm glad you've found the right page, any updates on why this is not working?
p
the latest PR you sent also shows token limit exceeded.
d
Well I'm not sure what to tell you, I haven't used Graphite in this organization at all, and I've turned the repos of the other org off, haven't used it in a few hours, so not sure why this could be happening, seems like an error with graphite?
TTD has a big engineering org and we would love to pilot your software, but it doesn't seems to be working
p
I am looking into how this could be that you continue to hit this error with such a small scope.
d
Hey, just checking, any updates?
Any chance I could please get some attention here? I'd love to demo this to the wider eng org but I still haven't been able to get the reviews with Graphite 😕
p
Good Morning Diego, i will bump the internal thread on how to track down how your PRs continue to go over the limit. Could you please send over the latest test of yours?
d
Thank you! Sure, the PRs that I have currently open are here: https://github.com/ai-codereview-testing-ttd/teamhub-frontend-graphite/pulls
We only need those reviews, so we can compare Graphite against other vendors
p
I notice too that you turned off your other repo which should help. Could you try pushing a single new PR to test on one of these repos? these are all stale and wont rerun without a change to them.
d
if i push any change, would that trigger a whole PR review? even if unrelated to that file?
p
yea you could try that too
d
Ok so I've tried this yet one more time, Graphite reviewed the branch/code but didn't seem to find any issues? I've deliberately introduced issues in this code but Graphite doesn't seems to have found any?
Also, all the other code reviewers tools just worked 😓
p
Hey Diego, this time around i can see the reviewer ran and did generate a comment but the critic (what determine the validity) returned false so nothing was posted. Seems like it has to do with missing context.
d
So what should we do, I've spent a lot of time getting this setup, it's clearly not working but I've tried everything on my end, can we escalate this? Otherwise we are going to have to go ahead without piloting Graphite
p
Hey Diego — at this point, it seems this is working as expected on our end. Our AI reviewer scans the change, but we also run a check on our confidence and validity before Graphite leaves any comment. In this specific example the AI reviewer wasn't confident in its comment due to lack of context, so it didn't leave one. We’re trying to optimize for useful comments over noise, and prefer to leave fewer useful comments that we're confident of. In any case, agree that it's a bad look to catch an intentional issue you created. I've escalated that to our team for more investigation. To be candid, we're doing a ton of work here after being acquired by Cursor to improve this experience. In the meantime, I don't want to block you on piloting Graphite. I'd recommend continuing to test it with other PRs. If you continue to get poor results, feel free to flag the urls here and I'll continue escalating.
d
This is very strange, Graphite is not really doing what is supposed to be doing in this case, despite quite blatant bugs. Can we try something, can you please delete my account? I'll try to set it up again from the start and see if it works, i can see graphite still reviewing code in my other org which I've removed, leading me to think is using the credits there
i want to start all over again and see if that works
p
I can delete your account though not sure how much it will help. I would also maybe suggest removing the graphite app from the integrations in github for your other account to ensure we are not interfering.
d
I've tried yet again, I've disconnected the account and reconnected, created new repos, with new PRs and no luck at all
both CodeRabbit/Greptile came back with results and the integration just worked
not sure what the issue is
at this point we are going to go ahead without Graphite, unless you're able to sort this out, I don't think there's anything else I can do on my end