Why is <this PR> still in “Needs your review”? I a...
# report-bugst
Tyler Laprade
11/13/2025, 4:42 PMWhy is this PR still in “Needs your review”? I approved it, so two of the conditions should not be met.
p
Pylon
11/13/2025, 4:42 PM(If applicable) To help us repro, please send the following if you haven't already:
- PR links, screenshots, and/or debug output if applicable
- Repro steps
- Does this happen consistently? Just to you or others on your team also?
- Is this a regression? Is the problem new?
- If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>Pylon
11/13/2025, 5:01 PMhey Tyler, other than a sync delay between the Inbox's state and the PR's current state the only thing that comes to mind there is if the filter condition for "Active reviewers do not include: tylerlaprade" is mismatching
t
Tyler Laprade
11/13/2025, 5:03 PMEven if that’s the case (doesn’t seem to be affecting other PRs though), shouldn’t the Review Required filter have excluded it?
p
Pylon
11/13/2025, 5:05 PMah yes as well, I think that confirms it's due to the Inbox data for the PR being stale vs the actual in GitHub
t
Tyler Laprade
11/13/2025, 7:03 PMNope, something more bizarre:
Tyler Laprade
11/13/2025, 7:04 PMI haven’t touched this branch or even checked it out, but somehow GitHub says I did all these actions
Tyler Laprade
11/13/2025, 7:06 PMI manually merged the PR below this one (not by me, and not by the author of this PR either). That seems to have mistakenly associated all these actions with me and blocked the PR.
Tyler Laprade
11/13/2025, 7:08 PMThis is really bad because it means I can’t ship my teammates’ work when they’re all on vacation or in another timezone (which is currently the case)
p
Pylon
11/13/2025, 7:12 PMwhen you say you "manually merged the PR below this one", did you do that from in Graphite or GitHub? The activity seen there looks to me to be automatic rebasing, which gets kicked off when a downstack PR is merged
t
Tyler Laprade
11/13/2025, 7:12 PMGraphite
Tyler Laprade
11/13/2025, 7:13 PMI would expect automatic rebasing to be associated with the author of the stacked PR
Tyler Laprade
11/13/2025, 7:17 PMAssuming this bug also occurs with automatic merges, that would mean a team of two that stacks on top of each other would never be able to merge