I have a PR changing files of which I'm the sole code owner. The PR has been approved by someone. Still, I'm seeing

Needs approvals from file owners

and and the attached message. Why is this happening? How can I debug it? To add: I am able to merge on GitHub. I'm not sure how to provide context, as this is a private repo. Please let me know if I can somehow provide more info.

(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using

gt feedback --with-debug-context <any message>

@Gareth Brickman did you receive the email by @Pim de Haan?

To add: I've added more CODEOWNERS, who have approved my PRs, yet still couldn't merge in Graphite (I could in GH)

Background: I'm trying to introduce graphite at our organization after having used it extensively at my last job but this issue appears to be a blocker for convincing the team 🙈

Yes. It seems the issue is the Graphite PR page can't handle this corner case where the PR's author is also the sole codeowner (and hence can't approve their own PR). I've ticketed this as a bug to the team.

Thank you! Is it possible for you to predict a rough eta for the fix? Fully understand if not possible.

this corner case where the PR's author is also the sole codeowner (and hence can't approve their own PR).

So this turned out not to be the (only) issue

No ETA as yet

@Gareth Brickman we have 7 days on our trial left and I need to convince finance that the team wants to adopt Graphite so that we can purchase a plan. Our engineers do but they are complaining a lot about the code owner issue 🙈

hey Fabio, the team is still investigating this as a possible cache issue on our end. I'll keep you informed of any progress

Thank you!

in some cases the root cause for this has been Graphite's state of team membership and designated code owners falling behind the current state in GitHub. In these cases Graphite is eventually consistent and gets back in sync with GitHub without any intervention. In other cases though there can be a different root cause. Pim has indicated one such where they are the PR author and the sole code owner but can't approve their own PR in Graphite. To help our team investigate, may I ask either of you to please create a stub PR that reproduces the erroneous

Needs approvals from file owners

and leave this PR open.

Will do. Thanks

hey Fabio and Pim, thanks again for bearing with us. I do have an update that this is root causing to your specification of the codeowners via email address instead of GitHub username. We're looking into fixing that on our end but the ETA for it is indeterminate currently and I will keep you posted about that. In the meantime a workaround would be to edit the codeowners to use their GitHub usernames and our system should then be eventually consistent and sync with those to recognize the approvals correctly.

Oh, sure, will do. Thanks!!