Is there some catch to getting the Graphite Editor...
# report-bugs
t
Is there some catch to getting the Graphite Editor to
Apply changes
? I click the button but there's 0️⃣ feedback in the UI.
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
t
I see this in browser console log when I click: >
Called applyUnifiedPatchFromChat without conversation id
also tried seeing if maybe Graphite Chat had some tools/context and could do it for me -- alas it has no idea what "apply the change" means in the context of the graphite editor
p
Hey Tyler, I cannot see what took place in the chat outside of your screenshot but here is a simple test i did: 1) ask for suggestion 2) tell it to apply one of the changes it suggested 3) click apply after i click apply i see an indication (spinner on the blue button) that its making the change, and once done there will be a line that says "*Changes applied"* Let me know what workflow you took so i can see whats happening~
t
@Brett Bedevian I'm referring to the graphite EDITOR: > Is there some catch to getting the Graphite >>_*Editor<<*_ to
Apply changes
?
you can see enough in my screenshot to identify it as the editor's chat, not the PR chat 🙂 the
Apply changes
at the top. the chat within the editor (not on the main page) was more of a last ditch effort because the
Apply changes
doesn't work.
user story if helpful... > User cannot apply changes in the Graphite Editor (PR page > "..." at top > "Open in editor"); making changes in the editor and clicking "Apply changes" does nothing.
p
Aha! my apologies i totally misread! Yes i see this behavior as well. I will log this as a bug. As a short term solution, I got it to work by making a simple statement to the chat and then it allowed me to click the apply changes button.
🙏 1
💡 1
t
(tried to use editor again today and it was broken still)
p
thanks for the bump here tyler, this is on the teams radar
t
appreciated - i won't bump too often, mostly just providing more data every few weeks if i notice/remember. got it out of the state by using the chat like you did last time 👍
got the actual apply button to work today, but took these steps 1. open the editor 2. make a change in it 3. click apply 🐛 does nothing 4. say anything in chat 5. click apply -> it works this time? ✅ maybe... apply doesn't work unless the chat has been used in some way?
p
thats correct, today we are checking for a chat. This is on our radar to improve.
👍 1
hey Tyler, circling back to confirm the in-app editor no longer requires a chat to be started to apply changes 👍
👀 1