This recently added speedbump is responsible for c...
# report-bugs
t
This recently added speedbump is responsible for countless cases of thinking I submitted changes to a PR, only to find hour later that it is still sitting unreviewed since my changes are not submitted. This is especially bad when I script out complex commands, such as only doing
gt m -a && gt ss -mp
after running some tests, for example.
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Tyler, thanks for your feedback here. This is a tight balancing act as we want to put up guardrails that can prevent users getting themselves in unwanted states while of course not wanting to hamstring the general usability flow needlessly. At the present we're opting to preserve this prompt as the default behavior and do provide a bypass for it via the
--ignore-out-of-sync-trunk
flag which you can configure in
gt aliases
to always be run with the
gt ss
macro.
t
Please help me better understand the intention of the guardrail. With a large, fast-moving team and a healthy merge queue, this is going to trigger nearly 100% of the time.
p
The main issue this is meant to guard against is users performing manual operations outside of
gt
, such as manually creating branches based off
origin/main
and then submitting against an out of date
main
. User actions such as this can cause
gt
to be performing operations against the wrong commit and so utilize incorrect metadata for the submission, leading to incorrect PR title/descriptions.
t
Okay, that makes sense to me. However it seems to be incorrectly triggering even in cases where that doesn’t occur, since my team solely uses Graphite for creating/submitting branches, and we use Graphite’s auto-merge rather than merging in GitHub.
➕ 1
j
I've also seen this incorrectly trigger for myself. I know the CLI team is looking into instances of this issue, if you're able to provide a test repo with a set of minimal repro instructions that would be super helpful for them!
👌 1