Graphite broke our main branch by merging unsigned...
# report-bugs
b
Graphite broke our main branch by merging unsigned commits
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
b
Graphite has bypass access as per documentation for the merge queue to our ruleset
we have a single ruleset for our main branch which enforces required PRs as well as all commits being signed
not sure of the exact trigger within graphite that caused this to happen, but would appreciate 1. a deeper understanding of how this happened 2. how we can avoid this in the future (do we make 2 different rulesets, 1 for requiring prs which graphite can bypass, and another for everything else which we don't want graphite to bypass)?
p
hey Bhav, I think your approach in #2 to compartmentalize rulesets should work as going by our docs the Graphite app only needs to bypass the required pull requests rule
👍 1
b
Thank you Could you help me understand how this could have happened in graphite? Up until this point, we haven't had this issue. Are there any logs we could inspect somewhere?
p
could you share a link to the particular PR in Graphite?
b
We did some debugging and figured out what had happened - prs in the middle of a stack wouldn't flag if a commit was unsigned, only the bottom most pr in a stack since that was against the main branch we just updated our rulesets check for signed commits against all branches matching a prefix and forced people to configure to use a branch prefix in graphite (via another ruleset)
we're all set here - thanks for the quick reply!