how does graphite get the required checks from a r...
# report-bugs
e
how does graphite get the required checks from a repo? Graphite is showing that certain (old) checks are required and preventing merging whereas Github doesn’t show these checks anywhere that I can find. Our required checks are defined in
Repository Settings > Rules > Rulesets
as far as I know.
✅ 1
➕ 2
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
e
PR link: https://app.graphite.dev/github/pr/project-nous/monorepo/14844/remove-retool-deployer-container-definition yes it happens on every PR and it’s happening to the whole team, it’s a new problem
p
hey Ed, thanks for those details. We are investigating
e
thanks 🙌🏻
p
I do see both those PRs waiting on 3 required checks. Could you double-check the details in GitHub if they're showing in there? https://github.com/project-nous/monorepo/pull/14844#partial-timeline https://github.com/project-nous/monorepo/pull/14846#partial-timeline
e
One of them has now been merged (in github), those checks are not shown on https://github.com/project-nous/monorepo/pull/14846#partial-timeline They are the names of checks that we used to run (and used to be required) but we don’t any more Partial screenshot of the checks on github attached. The
Web unit tests (batch x)
checks would appear in this section of the list if they were required by Github.
image.png
p
gotcha, do you know if those checks were removed or not set to be required? And how long ago that happened? Was it after these PRs were created?
e
They were removed and set to not be required. No it was before. At least one of those prs was created today. Can show you GitHub settings if helpful?
I actually looked at GitHub history and the checks were removed several months ago
👍 1
t
Just to add, we're having the same issue. We had a required check that was removed a couple of months ago, and now this check is showing as required on Graphite, but don't show at all on GitHub.
I tried adding the rule old rule on GitHub and removing it again, then running the checks again from Graphite, but is still showing as required on Graphite
p
hey TherPianist, could you please use the
Send feedback
option from in the Graphite app's Help menu on the impacted PR's page. I can then append your report to our internal tracking ticket 👍
t
I just did, thanks!
p
Update: the engineering team believes both issues have the same underlying root cause and are implementing a fix. Will confirm when it is deployed. Thanks for bearing with us and apologies for any inconvenience caused 🙏
The fix is deployed! Please refresh/reload any impacted PRs and the status checks should show the correct states
t
I can confirm the issue is already fixed for us. I also saw the email you guys send me on the ticket. Thanks!
e
Hey yeah confirmed that the issue is fixed for us too, thanks! 🙌🏻