hey there, the past couple of days, I’ve had PRs w...
# report-bugs
t
hey there, the past couple of days, I’ve had PRs where updating the branch has led to re-requesting review from already-approved PRs. It doesn’t prevent me from merging, but it’s a bit annoying for the reviewers. Is it something on your end or GitHub?
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
t
Could it be something like I use the command line to submit a new branch on the stack and I use the command line parameter to request a specific reviewer, and it resubmits the whole stack but also requests the reviewer on all of the branches?
I usually use
gt submit -npr david,goliath
for each branch
p
hey Tim, do you know if the repo has the Branch Protection enabled for
Dismiss stale pull request approvals when new commits are pushed
?
t
let me check
it used to work and I’d be surprised if anybody had changed that
image.png
I checked all of the settings from that page and they look good
image.png,image.png
p
thanks for checking that. I think it could be your theory about specifying the reviewer in
gt submit
. Maybe it's updating the reviewers in all the pull requests from trunk to current branch.
t
yeah, but that seems like a new thing because I’ve been submitting my branches this way for a long time