When github's security bot marks an issue as fixed...
# report-bugs
r
When github's security bot marks an issue as fixed in a PR, that closure isn't reflected in graphite, leading to a heap of stale threads that aren't resolvable but still appear in the sidebar as unresolved, but are marked as 'fixed' in github's PR view. Is there a way to get that fixed status synced across and marking those threads as resolved?
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Rory, would you mind please DMing the URL to that PR in Graphite and I can refer it to the team as an example
👍 1
r
Sent. I've had a squizz at the GIthub API. it looks that while the UI is showing it as fixed, the actual comment state is still listed as unresolved. I'll see if I can find the relevant GraphQL query to get that fixed state - and then you can decide what you want to do with it
(Very strange that Github will mark something as fixed/stale, but keep the comment open T_T )
Ok yep, that looks like it might be pretty annoying. You're likely going to need to: Check to see if any comments are by hte github security bot. If so, • get the security alerts for that branch/sha/etc • Correlate teh comment to the scan result • If fixed, maybe mark the comment as resolved? If I get time later, I'll try put together a gist with the example data but have a few other things on the list today
👍 1