Hello! I had a stack with main -> A -> B -&g...
# report-bugs
s
Hello! I had a stack with main -> A -> B -> C, all got approved and decided to merge the stack. However, A got merged, B needed a re-approval (not sure why), C got merged into a
graphite-base/
branch and got closed. I had to reopen C, create a new PR, get approvals, and then merge it into
main
. Am I doing something wrong or was there an issue here? Trying to understanding what happened here.
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Sasank, would you mind please sharing the URL to the stack in Graphite and will have a look
s
Just DM'ed you the link!
👍 1
p
did you select
Merge When Ready
for the stack, or did you manually select the
Merge
button?
s
Pretty sure I manually hit the
Merge
button
p
wasn't able to see from in the PR activity why this occurred. Can only assume something went wrong while Graphite was performing the stack merge, perhaps the state between Graphite and GH got out of sync or a race condition. If it reoccurs again please use the
Send feedback
option from in the Graphite app's Help menu. That will help to provide us with more information and logs for debugging on our end, thanks!
m
p
Could you check in your repos' branch protection rules if either of these is enabled: 1. "Dismiss stale pull request approvals when new commits are pushed" 2. "Require approval of the most recent reviewable push"