I had a PR that was all ready to go (green and up-...
# report-bugs
t
I had a PR that was all ready to go (green and up-to-date with
main
). I had added our merge queue label before the build finished and thought the queue would merge it quickly. Instead Graphite pushed a new commit which triggered a new build, delaying the final merge. Not a big deal in this instance but I’d like to understand why because that’s wasteful
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
t
this is the PR where it did this: https://github.com/superhuman/desktop/pull/28576
and CI failed that time, so that’s a double whammy
actually worse because that made Graphite kick the branch out of the queue…
I should have just pressed the “Squash and merge” button when I saw it… 😕
p
Hi Tim
t
hello… Connor
❤️ 1
Any update on this? It just happened again, and it’s frustrating to see the PR having to wait another 5-7 minutes because a new build started
and like last time, the build failed so that pushed the merge ever further
p
Hey Tim, Ive been looking through this with a colleague just want to make sure our understanding of the issue is correct here: • Tim enqueues PR in GHMQ • PR is evicted because of a CI failure • PR cannot be re-enqueued (potentially because it was rebased) and now we need to wait for required checks to pass again • Checks eventually pass and we can re-enqueue • Checks need to pass again in the MQ If this isnt exactly correct, could you let us know where we're off? Cheers, Brett B
t
no that’s not it. The branch (and the whole corresponding stack) was up-to-date with
main
, with all necessary approvals and builds had passed. I could have clicked “Squash and merge” on GitHub. Instead, I went to Graphite, and clicked “merge stack”. I had three branches at the time and they were all approved. We use the Graphite merge queue. Once I did that, I expected Graphite to just merge the branch immediately since it was up-to-date with
main
and all green. Instead, Graphite pushed a new version to the branch, which triggered a new build to start. That build unfortunately failed (flaky test), which kicked the whole stack out of the Graphite merge queue. So I had to restart the builds, and add the stack to the Graphite merge queue again.
the flaky test that made the build fail is one thing on our end of course
but it’s frustrating to have the branch ready to merge and one click away, only to see an unnecessary new commit pushed out. Just that adds 5 minutes of build in the best case.