We just have an interesting case with multiple tru...
# report-bugs
m
We just have an interesting case with multiple trunk configurations. Just to quickly explain the setup: • Engineer A creates a stack of 2 PRs (amount doesn't matter) on
main
(our default trunk) • Engineer B does a
gt move
onto another trunk (configured locally), lets call it
release-B
. And does a
gt submit --stack
and the review shows nicely that the 2 PRs are now depending on
release-B
and not
main
anymore, • Engineer A does a
gt sync
but nothing changes • Engineer A instead also defines
release-B
as additional trunk and then does a
gt sync
on their 2 PRs and only not they are showing up in the correct location. To us that is a bug because Engineer A only didn't push and overwrite the changes from Engineer B because they are sitting next to each other. But otherwise they would have not be notified. I would enjoy to get a message that says, your stack has been moved to an alternative trunk, do you want to sync this move locally, similarly to when it happens that somebody adds a PR into your stack you also get such a message (which is amazing btw).
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Manuel, thanks for your feedback about this multiple trunk case. I believe this is due to the necessity for the additional trunk branch to first be configured in the repository-level settings.
m
yes, but there must be a notion of it, given that the review app shows the new trunk. Hence, the user should at least get a warning that their local branch has been moved to another place and require to setup the trunk accordingly to see the move. Currently, in the example above, Engineer A would just not be aware of it and another submit would overwrite whatever Engineer B moved. And silently just doing anything is bad and to me a bug. A warning message would not be the ideal solution but certainly better. Ideally one can just ask if the user wants to add the new trunk as well and perform the move also.