I'm using the <dismiss-stale-approvals> gh action ...
# report-bugs
n
I'm using the dismiss-stale-approvals gh action and it seems to be dismissing approvals when graphite merges a branch into main, usually due to the commit message changing? I'm a bit confused by this
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Nicholas, according to the docs that GH Action will dismiss approvals for non-rebase changes
n
that part makes sense. This is the scenario that is confusing me 1. Make changes 2. Update description of PR 3. graphite PR approved and ready to merge 4. click merge in graphite 5. it seems like graphite force pushes at this point to overwrite the commit message to include the description that was changed after commits 6. CI runs on the force pushed commit (including the dismiss approval GH action) 7. dismiss approval GH action sees changes in description and dismisses approvals (see screenshot for diff produced by GH action) 8. get re-approval and merge again 9. things go through the second time
p
gotcha, will try reproduce it
👌 1
n
Any update on this?
p
hey Nicholas, this one got pushed down my stack so I haven't repro'd yet but I intend to if I can 👍
n
Great :)
p
hey Nicholas, I think I was able to reproduce this. When this happens to you, could you please share the
dismiss_stale_approvals
GH job logs so I can compare to mine?
n
@Gareth Brickman I'm a bit unsure about sharing that. Not sure if there's anything that's sensitive in the logs. since you were able to reproduce, what's the latest on this? Sorry I haven't responded in an extended period..
p
hey Nicholas, sure no need to share them with me. The specifics of why the GHA acted as it did for the particular run will be contained in those logs.
n
ah okay
let me know if I can provide any more information to help move this forward.
sorry about that
p
The conclusion I reached when I was reproducing it is the GHA's internal logic does act conservatively and from the team's feedback that is intended. You're able to fork the GHA's code and adjust according to your needs if any behavior is undesired.
n
ah okay, that's too bad. I wonder if there's some configuration we have that causes this to happen since it's happening very frequently for us.