This message was deleted.

Seems to depend on where the focus is. If you for example first click into the search bar or open the keyboard shortcut help, pressing ESC still brings you back to the dashboard

@David Balatero has been fixing a lot of focus/`ESC` key interactions so it should work a lot better/how it was originally intended to! We’re also going to ship a toggle to use

‘

instead of

ESC

for the vim folks :)

That's great news @merrill! Thanks for the upcoming toggle! (I'm not a vim user, but I do still mash escape sometimes for some reason)

Seems to depend on where the focus is. If you for example first click into the search bar or open the keyboard shortcut help, pressing ESC still brings you back to the dashboard

@Vampire hmm, I can't repro that, do you have specific steps i could try?

Well, it is exactly what Ben also said. If you just open any PR and then press ESC, you are not being taken to Dashboard.

i think maybe i didn't understand your comment?

If you for example first click into the search bar or open the keyboard shortcut help, pressing ESC still brings you back to the dashboard

it sounded like you were saying "when I click into the search bar, and the search bar is open, pressing esc takes you back the dashboard instead of closing the search bar"

I was a bit blurry, sorry. If I open a PR an press ESC, nothing happens. If I then click into the searchbar, the search opens. If I then press ESC the searchbar closes. If I then press ESC again, I'm taken back to the dashboard.

thanks! yeah it feels like something is not being registered until that "click into searchbar" happens, which is odd

Yeah, seems to work better again, thanks. 🙂 Sad for the creator of this thread though 😄