This message was deleted.
# feature-requestss
Slackbot
11/14/2023, 5:51 PMThis message was deleted.
p
Pranathi Peri
11/14/2023, 7:12 PMHey there! I don't believe the merge button is disabled here - there is just a warning icon indicating that you might be bypassing some requirements
Pranathi Peri
11/14/2023, 7:13 PMUnless it's disabled on the modal after you click this merge button?
a
Anton
11/14/2023, 8:55 PMIt is disabled, but I can overwrite it using my administrator privileges. The danger with that is that with that button I can also override automated CI checks.
I haven’t tested if it’s different when having no admin priviliges.
p
Pranathi Peri
11/14/2023, 8:55 PMHmm interesting. Is the PR mergeable on GitHub?
Pranathi Peri
11/14/2023, 8:55 PMWhat do the warnings on the merge modal say in Graphite?
a
Anton
11/14/2023, 8:57 PMSadly, I can’t look at the warnings anymore, as I’ve since merged the PR
It was definitely mergable in GitHub, with a green merge button. GitHub does warn with red text about the “needs changes” review. But it doesn’t make the button disabled like it would if the review is required.
p
Pranathi Peri
11/14/2023, 8:57 PMHmm ok good to know! I think we can do a better job of allowing a merge here so that we're 1:1 with GitHub, I'll raise this with the appropriate eng 🫡
🙏 1
Pranathi Peri
11/14/2023, 10:38 PMAh turns out GitHub changed some logic recently that we need to update on our end so that this works as intended - we're working on getting a fix out soon!