This message was deleted.
# feature-requestss
Slackbot
11/09/2023, 8:21 AMThis message was deleted.
➕ 1
s
szaman
11/09/2023, 9:51 AMisn't this a github setting on your repo? something like "require approval after changes"
t
Tyler Laprade
11/09/2023, 9:52 AMNo, that’s not quite what I’m asking
Tyler Laprade
11/09/2023, 9:53 AMI do have that setting enabled, and I’m not willing to disable it for various reasons. When I manually stacked PRs before Graphite, the base would change automatically when the previous PR was merged. Since no code changed in the next PR, GitHub didn’t dismiss reviews. Graphite does something different - it forces a “rebase” to occur, which does cause GitHub to dismiss reviews.
👀 1
Tyler Laprade
11/09/2023, 9:54 AMIt kinda defeats the purpose of code reviews if you disable that setting, since the approved code might be nothing like what actually gets pushed
z
Ziyao Wei
11/09/2023, 1:49 PMthe base would change automatically when the previous PR was mergedDid you have the setting where a branch is removed when it is merged on?
t
Tyler Laprade
11/09/2023, 2:02 PMYes, I do. I don’t like old branches building up because it’s hard to figure out which ones you still need
p
Pranathi Peri
11/13/2023, 4:33 PMSince no code changed in the next PR, GitHub didn’t dismiss reviews. Graphite does something different - it forces a “rebase” to occur, which does cause GitHub to dismiss reviews.Hmm so when you were manually stacking branches before, you weren't rebasing PRs before merging them into main?
t
Tyler Laprade
11/14/2023, 1:24 AMThat’s right, GitHub always seemed to handle it fine. Although I never built a stack of more than 2 PRs like that.
2 Views