https://linen.dev logo
Join Slack
Powered by
This message was deleted.
# feature-requests
s
This message was deleted.
d
does 
gt submit -r <team name>
not work?
w
nope. and @Alyssa Baum in #how-do-i said requesting reviews from teams is not currently supported.
👍 1
z
w
(in the CLI, I can do it in the web app but I have to search for the team. it's not in the list)
j
(i currently do this via 
gh pr edit
)
😅
😅 1
i went and looked in our codebase to see if i could add this really quickly but the github api is quite annoying about wanting the individual and team reviewers in two separate string arrays, so i think we'd need to add a new flag to the cli
d
are all teams of the form 
prefix/team-name
?
or was that just my old job
(if so, could we split on 
/
to get the 2 array parts?)
z
They have to be since team names are scoped per org (I think), so the first part is the org name
E.g., you can have @withgraphite/ZiyaoWei as a team
d
haha is that a 1 person team you made up
😅 1
"only Ziyaos can join"
w
Did this end up with an implementation approach, at least? Curious if the 
/
heuristic or similar ended up panning out.
ping? :)
d
i'm not sure, @Jacob Gold do you think splitting on 
/
could work?
j
i do think it would work as github doesn't allow slashes in standard user names. i think i'd prefer a separate flag in the long run in order to keep folks from having to type out 
@longorgname/team
, but no reason not to split on 
/
when we see it in the 
-r
array. should be able to put up a quick fix some time soon!
and it would be a server-side change so wouldn't require a cli release cycle 🙂
🔥 1
thanks for the ping
w
awesome! thanks for the update!
I'm demoing Graphite for the rest of my team next week and having this would allow me to say, "And you can request the team's review right from the submit command" instead of "This is the most annoying manual part of the o/w great workflow." 🙂
👍 2
d
@Jacob Gold i'd definitely use it internally as well since we do a lot of team-based assignment now, lmk if you want help
👍 1
> in order to keep folks from having to type out in the absence of autocomplete, my recommendation is always 
fzf
(https://github.com/junegunn/fzf) for recalling commands you run a lot (like stack submit + assign to my current team) 🙂
j
i threw you a pr 🙂
✅ 1
🚀 1
you can now add team reviewers with 
gt s -r @org/team,@org/team2
. 
gt s -t team,team2
is shipping in an upcoming cli version
🔥 1
🙌 1
w
hmm, this did not seem to work (i.e. it did not request review from the specified team): 
gt submit --reviewers @fluree/core --publish --no-edit
j
let me double check that this landed to prod
👍 1
w
this still does not work for me, in case that's useful (rather than redundant) information 🙂
j
Ah, it was working on update but not create. Fix will roll out tomorrow
👏 1
w
looks like it's working now! 🙌 thanks!
2 Views
Open in Slack
PreviousNext
Powered by