This message was deleted.
# feature-requests
s
This message was deleted.
d
To add to the above, my workflow when I work on big features is to usually completely implement the feature before I start breaking down to commits (or branches, with graphite). This way it is easier to group changes together, in a final structure, than doing that as I go, so staged changes that ended up there somehow may exist
j
Hmm, this is certainly an interesting idea — you can run
gt create -p
or
gt modify -p
to always be prompted, but perhaps making this configurable is a reasonable path forward. Out of curiosity, which IDE is this with?
d
I am using Pycharm/Webstorm. the
-p
argument (at least from my experience) will not prompt you for files/changes that are already staged. So if something has slipped by and has been staged already, it will automatically be included to whatever else you add when you run
gt create/modify
. What I propose would be a new functionality that lets you select from both staged and unstaged changes in order to control what to include in the
gt create/modify
and not automatically grab all the staged changes
j
You could alias
git reset && gt create -p
and
git reset && gt modify -p
?
d
hm, I'll give it a try. just to help you visualise what I mean though, for example Pycharm/Webstorm, shows you a list of every changed file, no matter if the changes are staged or unstaged or even if the file is untracked and you can select whichever ones you want, no matter their status, and commit them all together. What I suggested is essentially this functionality but from the graphite cli
right now the
create/modify
commands only let you select from the set of unstaged and untracked changes and excludes the set of staged changes (since it includes them all by default)
j
right, that's consistent with git. but you should be able to get this behavior with
git reset
. It sounds like Jetbrains is just ignoring the staging area here?
d
Yeah, I guess, it lumps staged and unstaged changes together and only separates the untracked files in their own group (I didn't have any in the screenshot 😛 )