This message was deleted.
# feature-requestss
Slackbot
10/17/2023, 4:29 PMThis message was deleted.
d
David Balatero
10/17/2023, 5:39 PM@Lou we're definitely supposed to preserve your descriptions if you try to resubmit - did that not happen?
David Balatero
10/17/2023, 5:40 PMit should prompt you with a "want to reuse the description you already typed out?" kind of thing
l
Lou
10/17/2023, 5:41 PMDidn’t get that. On version 1.0.6
Lou
10/17/2023, 5:42 PMWhen retrying it started with a blank template. Here’s the output
Copy code
louisssialm1mbp ~/code/spatial ✐ gt ss
🥞 Validating that this Graphite stack is ready to submit...
✏️ Preparing to submit PRs for the following branches...
▸ cleanup/lou-media-settings-effect (Create)
✔ Title … [cleanup] Ports screenshare settings state update effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-mic-input-saga (Create)
✔ Title … [cleanup] Ports mic input room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-rtc-channel-saga (Create)
✔ Title … [cleanup] Ports room rtc channel side effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-user-media-support (Create)
✔ Title … [cleanup] Ports user media support room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-rtc-perm-toast (Create)
✔ Title … [cleanup] Ports rtc permission error toast room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-register-screen-share (Create)
✔ Title … [cleanup] Ports screen share setting analytics registration room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-save-toasts (Create)
✔ Title … [cleanup] Ports save state toasts room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-capture-sagas (Create)
✔ Title … [cleanup] Ports screenshare and webcam start/stop room effects to sagas
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-disable-deps (Create)
✔ Title … [cleanup] Cleans up some spots disabling exhaustive deps lint rule
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-webcam-changes (Create)
✔ Title … [cleanup] Ports webcam changes room effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-custom-env-close-transform (Create)
✔ Title … [cleanup] Ports transform panel closing room effect to reducer
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-environment-change-saga (Create)
✔ Title … [cleanup] Ports environment change effect to saga
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-stream-selector (Create)
✔ Title … [cleanup] Consolidates stream selector function
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-room-render-selector (Create)
✔ Title … [cleanup] Moves shouldRenderRoom computation to selector fn
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
▸ cleanup/lou-auth-state-selector (Create)
✔ Title … [cleanup] Makes getAuthState a proper selector fn
✔ Body › Edit Body (using code --wait)
✔ Submit › Publish Pull Request
📨 Pushing to remote and creating/updating PRs...
cleanup/lou-media-settings-effect: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13951> (created)
cleanup/lou-mic-input-saga: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13952> (created)
cleanup/lou-rtc-channel-saga: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13953> (created)
cleanup/lou-user-media-support: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13954> (created)
cleanup/lou-rtc-perm-toast: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13955> (created)
cleanup/lou-register-screen-share: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13956> (created)
cleanup/lou-save-toasts: <https://app.graphite.dev/github/pr/spatialsys/Spatial-2.0/13957> (created)
ERROR: Failed to submit PR for cleanup/lou-capture-sagas: Looks like you've triggered a GitHub API secondary rate limit 🥞 Nice stack!
Please wait a moment and then try your submit operation again.
louisssialm1mbp ~/code/spatial ✐ gt ss
🥞 Validating that this Graphite stack is ready to submit...
✏️ Preparing to submit PRs for the following branches...
▸ cleanup/lou-media-settings-effect (No-op)
▸ cleanup/lou-mic-input-saga (No-op)
▸ cleanup/lou-rtc-channel-saga (No-op)
▸ cleanup/lou-user-media-support (No-op)
▸ cleanup/lou-rtc-perm-toast (Update code)
▸ cleanup/lou-register-screen-share (Update code)
▸ cleanup/lou-save-toasts (Update code)
▸ cleanup/lou-capture-sagas (Create)
✖ Title … [cleanup] Ports screenshare and webcam start/stop room effects to sagas
louisssialm1mbp ~/code/spatiald
David Balatero
10/17/2023, 5:52 PMok, thanks - that's helpful and sounds like we hit a regression on that. cc @Jacob Gold
David Balatero
10/17/2023, 5:52 PMI'll capture a ticket
David Balatero
10/17/2023, 5:54 PMsorry you hit this @Lou, it's super frustrating to lose that much work
l
Lou
10/17/2023, 7:52 PMThanks for addressing it
👍 1