This message was deleted.
# feature-requests
s
This message was deleted.
d
There is some configuration that can impact this behavior. I'll to try enumerate the behavior here, but feel free to ask for more details about your specific case. • If you are attempting to merge a single PR, this shouldn't apply as the CI should have completed before we enable the merge button. • If you are attempting to merge a stack of PRs, there are a few options that can be selected to configure this behave. ◦ "Ignore optional CI status checks during the merge process": If this is enabled, we will not wait CI checks that are not required. ◦ "Use your admin privileges to ignore any unmet requirements": If this is enabled, we will not wait for required checks to merge (assuming the user merging has permissions to bypass the checks) • For "Merge when ready", we will not wait for optional checks, but we will wait for required checks. • For merge with our merge queue, we will not wait for optional checks, but we will wait for required checks.
k
Thanks David, that's very useful! So the only situation where we're forced to wait for optional checks is displaying the merge button. Is the discrepancy intentional, or perhaps it can be brought in line with the merge queue behaviour?
d
So the only situation where we're forced to wait for optional checks is displaying the merge button.
Not just displaying the merge button, but it could occur during a stack merge as well. Since multiple stacks can be merging at the same time, we may need to rebase PRs during the merge process, which can trigger new CI runs. In those cases, we may or may not wait for any optional CI depending on the options selected where the merge was started.
forced to wait for optional checks is displaying the merge button.
If only optional CI is running, the merge button should be available and enabled, but it should have a warning that optional CI is still running. You should still be able to trigger the merge and skip the optional CI if you want to.
👍 1
k
If it's already available to press, but has a warning about optional CI still running it's perfect. Thanks @David Bradford!
> • For "Merge when ready", we will not wait for optional checks, but we will wait for required checks. I think I have an example of this not being the case: 1. I toggled "merge when ready" for a PR (second in a stack of 2). It was added to the merge queue. 2. At some point it moved to the first spot in the merge queue. 3. Required checks have completed. 4. Optional checks took ~4 more minutes to complete (after required checks were done). 5. The PR wasn't merged at point (3), but as soon as (4) was done. I have a Loom of waiting for the PR to merge while optional checks were still running. Let me know if I should share it with you in DM!
d
Yes, if you can DM me the details, i can take a look at what happened.