This message was deleted Graphite Community #report-bugs

Join Slack

This message was deleted.

# report-bugs

Slackbot

08/18/2023, 4:42 PM

This message was deleted.

Ben Jaffe

08/18/2023, 4:43 PM

clicking the "viewed" checkbox or expanding the file causes the UI to crash and go all grey.

archiveresale/archive/5734

1. probably should have an error boundary here 2. more importantly, this is preventing me from fully reviewing since I don't know if there are changes in this viewed file

Ben Jaffe

08/18/2023, 4:44 PM

Copy code

Uncaught Error: Unable to render a collapse reason because collapsedReason was undefined (we should not get here!).

  fileKey: web-app/src/theme/brands/alc/HierarchicalNavigationWrapperTemplate.tsx::web-app/src/theme/brands/alc/HierarchicalNavigationWrapperTemplate.tsx
  rawCollapsed: undefined
    at main.6e77e847.js:2:6361638
    at Object.useMemo (main.6e77e847.js:2:2220094)
    at W.useMemo (main.6e77e847.js:2:2478787)
    at CollapsedFileDiffViewer (main.6e77e847.js:2:6361213)
    at main.6e77e847.js:2:4485803
    at main.6e77e847.js:2:4484856
    at trackDerivedFunction (main.6e77e847.js:2:4184772)
    at Reaction.track (main.6e77e847.js:2:4189584)
    at useObserver (main.6e77e847.js:2:4484831)
    at observerComponent (main.6e77e847.js:2:4485772)

Ben Jaffe

08/18/2023, 4:45 PM

3. in this particular situation, it'd be nice to have a way to reset "viewed" state for all the files, so I can see everything when doing this comparison

Ben Jaffe

08/18/2023, 4:46 PM

for now I can unblock by using GH UI to do this review

Pranathi Peri

08/21/2023, 3:59 PM

Hmm thanks for flagging - I'll raise this!

Open in Slack

Previous Next