This message was deleted.
# report-bugss
Slackbot
08/09/2023, 4:48 AMThis message was deleted.
d
David Balatero
08/09/2023, 2:34 PMwhat are those 2 screenshots? is one github and one graphite?
David Balatero
08/09/2023, 2:35 PMthey seem identical to me? can you call out explicitly what you're finding weird because i'm not getting a good sense from the screenshots alone
👀 1
b
Ben Jaffe
08/09/2023, 5:01 PMyes! Look at the text where it says "we are committed to limiting t<RANDOM LINE BREAK>" on the left (Graphite), versus looking normal on the right
d
David Balatero
08/09/2023, 5:10 PMcool, do you mind sending me an exact copy paste of:
• that line, on
mainDavid Balatero
08/09/2023, 5:10 PM@kush i think/hope this is just a word-break css thing that we can tweak
David Balatero
08/09/2023, 5:11 PMwe probably want to break on words/whitespace vs. chars
David Balatero
08/09/2023, 5:11 PM(we can also just see what css github uses for breaks and try to use that)
b
Ben Jaffe
08/09/2023, 6:03 PMthere are no actual breaks there... I think it's breaking after a number of characters
Ben Jaffe
08/09/2023, 6:05 PMI'll try and get to it, but it might be a bit before I can
d
David Balatero
08/09/2023, 6:31 PMsure - just feel free to copy the line from the left side and paste it here
Copy code
inside triple ticksDavid Balatero
08/09/2023, 6:31 PMand same with the right
b
Ben Jaffe
08/09/2023, 8:48 PMoh, I don't think the change in the string actually matters for it
Ben Jaffe
08/09/2023, 8:48 PMbut maybe? Are you having trouble reproing?
d
David Balatero
08/10/2023, 1:36 AMthe easier the repro the faster i'll get to it 🙂
David Balatero
08/10/2023, 1:36 AMbut i can try a random string, i just thought it would be better to use the string that was causing you weirdness
David Balatero
08/10/2023, 1:37 AMand/or to capture it in a ticket for someone else
b
Ben Jaffe
08/10/2023, 4:24 AMTotally. My covid brain can’t find the pr, which is ridiculous, it should be easy. Man, covid is no joke
❤️ 1
Ben Jaffe
08/10/2023, 4:25 AMI’d just make a pr with a long string in some jsx. If I get another moment tomorrow I’ll try and find the pr again
d
David Balatero
08/10/2023, 1:43 PMno prob, i'm sure i can repro!
David Balatero
08/10/2023, 1:43 PMoh my default dummy test PR is this RFC, i'll just line wrap it and see what happens
David Balatero
08/10/2023, 1:47 PMhm this diff doesn't look bad to me
David Balatero
08/10/2023, 1:48 PM@Ben Jaffe just search your editor for that string, then
git blameDavid Balatero
08/10/2023, 1:49 PMalso i can't tell if you're in split view or not from your screenshot
David Balatero
08/10/2023, 1:55 PMok, so the edit has to be big enough–i think our character-level highlights don't wrap correctly
David Balatero
08/10/2023, 1:55 PMas they have an extra
<span>David Balatero
08/10/2023, 1:55 PMyou can only really see it when you change an entire sentence worth of material
b
Ben Jaffe
08/10/2023, 2:15 PMAh yay, you reproed!
Ben Jaffe
08/10/2023, 2:16 PMThe weird thing is I apparently haven't landed the change yet, so I can't search for it. But I also can't find which open PR it is. Do you still want me to try and find it, or is your repro enough?
Ben Jaffe
08/10/2023, 2:17 PMThis pops up for me each time we build a brand site and insert all the marketing copy. It's not the worst issue or anything... mainly it's just not confidence-inspiring when comparing Graphite/Github review UI, so I wanted to report it.
k
kush
08/16/2023, 4:24 AMwe have a fix for this which should be available soon!
3 Views