This message was deleted.
# feature-requests
s
This message was deleted.
j
L
followed by
G
will copy the link to the GitHub PR page for you β€” out of curiosity, what are you finding you need to navigate to GitHub for?
πŸ‘ 1
t
i still prefer the github UI for actually looking at code. just little nits that I'm not quite used to in graphite
p
Ooh interesting, we're always looking for feedback on the code display! Is this more related to syntax highlighting, font, or something else?
βž• 1
t
like, i don't like how i have to click on the "Files" icon to see the changed files (the sidebar defaults to general info)
and.... is there a way to just show the diff from a single commit vs all commits?
b
ooh, I'm glad there's a keyboard shortcut now!
L -> G -> Cmd-L -> Cmd-V -> Enter
is gonna get into my fingers πŸ™ƒ
t
also, when I make commits, i often make multiline comments. only the first line shows up on the commit in graphite, whereas in github there's three dots i can click to expand to see the whole commit message
Yeah but.... why not just.... one mouseclick instead of 7 keyboard presses?
b
This is if I have to actually go to Github. The menu item is to copy the link right?
t
and like, the timeline view just feels a little cramped. i like how the conversation on github is a separate tab
it feels a little extraneous to see review comments in the timeline, click on it, and see the exact comment again in the code
if i'm looking at code, i'll scroll past the comment. if i'm looking at the conversation, i'll click into the comment if i feel like it. no need to smush the two workflows together
t
this is also a big complaint from my team -- it's one of the biggest annoyances i've fielded. I love using the Graphite UI for some things and the Github UI for some things... it sucks that the Graphite team doesn't treat us as adults in this regard. (in case it's not clear, none of the people in the screenshot are me -- this is all organic dislike for the lack of redirects)
j
Sorry to hear that your team feels this way. We feel that the increased friction is worth it to try to understand what improvements we can make over the GitHub UI β€” if we believed this product was complete and that we'd done all that we could do already, we would have the link there, but we believe it will make the product better in the long run. I know that this may not ease the frustration, but I hope at least it helps you to understand why we continue to land on this side of that decision.
t
well, fwiw, i still appreciate graphite for the ability to make stacked diffs and merge them with one button in the UI. it's just unfortunate that you're fighting an uphill UI battle with github and other platforms for PR/merge/diff review
i just saw that the public CLI repo was archived a couple of weeks ago. I hope you guys win. The CLI is great
p
@Topher Brown hey there, this is actually a regression that is a result of us doing a re-haul on our onboarding process (which will be SO much better in the next week or so), we're prioritizing adding it back in now! Sorry this happened to you/your team
I'll let you guys know as soon as that fix is merged in! cc @kush
j
re β€” the "wtf is this" comment β€” we only do that when someone comments on unchanged lines, because github doesn't natively support showing changes 3 lines above/below lines that are changed. I'll update that copy to make it clearer that that's why we're adding the comment there
@Topher Brown to be clear on the above β€” the regression is that Graphite should give you a link to GitHub if you click on a Graphite PR link and aren't logged in β€” extremely sorry that we broke that, our intention is never to prevent non-Graphite users from getting to the GitHub PR page
I misread your original message and thought you were referring to the GitHub link for Graphite users (because that was the original subject of this thread)
t
yeah, the internal thread kind of devolved into "all of the above" β€’ glad to hear the non-Graphite user bug will be fixed! i know your team has put in some amount of work to make sure non-Graphite users aren't annoyed by their co-workers using Graphite β€’ re: Github copy; yeah, that feels like a tough problem. i've understood the issue and the fix, but i could see someone else being annoyed by it. love the idea of making it clearer. Github doesn't even let you comment on those lines! this is a value add feature which Github doesn't provide! lean into that πŸ˜„ β€’ i've been on both sides of the "keep users/data on your platform because that's how you'll 'win'" argument before. we're just not going to see eye to eye on this. if i'm paying $$$ and investing time enough to use your dashboard to get to PRs, it seems crazy to make it intentionally more difficult to have an escape hatch when occasionally needed. anyway, we created a Tampermonkey script to add the UI button ourselves πŸ˜…
πŸ‘ 1
k
dogpiling here~ the fix to bring back the link to GitHub has landed! sorry again for the regression here -- it was completely unintentional and we at graphite are committed to improving your team's workflow, especially when that means playing nice with flows besides ours that said, i want to echo that we're very interested in your feedback on the dashboard! knowing what your team finds disruptive and where we can do better helps us improve graphite and build a tool that you'll love using ❣️
🚒 1
b
@Topher Brown, @Ted Yeh I have a repo on GitHub with a few solutions that add buttons for this. I use the first option listed in that repo. It’s drastically decreased my stress to have a solution for myself, at least. (Not linking directly since that doesn’t feel right, but it should be easy to find).