https://linen.dev logo
Join Slack
Powered by
This message was deleted.
# report-bugs
s
This message was deleted.
āŒ 1
b
Another small thing: It was also jarring that the Cancel and Delete buttons in the modal don't feel standard at all (maybe cause they're extra small), and can't be keyboard focused.
(Maybe a different option is to have an undo button for destructive actions, like the way google does things in Google Calendar and their other products)
d
definitely agree with all this feedback
in general i'm a little suspicious of how much we have mapped to 
esc
, esp as you point out the disastrous effects that could occur by undoing your work
sometimes i hit 
esc
too much and i get backed out all the way to the root 
/
url
āž• 1
b
every day for me! šŸ¤£ šŸ˜­
d
also agreed on keyboard focus
we break standard tabbing flows wrt to buttons, inputs, etc
b
that said, it's hard to do right (says me, the person who definitely doesn't do it right all the time O_O )
d
one related issue is discoverability of the shortcuts itself--often you don't know you might be triggering a kb shortcut in the first place
šŸ‘ 1
these discussions have been coming up internally, and i'm hoping we can prioritize taking a stronger look at this entire area of problem soon
in the short term though we should probably make sure you can't just accept that dialog by hitting escape
let me see.
b
I think you can't already... I don't know how I accepted it,
but I did so without pressing enter
I thought I clicked on the modal backdrop, but that's working now...
d
you can confirm it with enter
you must have hit esc, enter
esc, esc will just open and close the modal but not destruct it
b
I don't think I hit enter... maybe I did...
d
you more or less had to have, or somehow you got the HTML to blue-ring focus around the button and hit space
those are the main options i can think of
i'm definitely prone to hitting enter sometimes though
esp since my caps lock key is enter
b
LOL
d
it's at least more brushable sometimes than usual
b
Ah, escape - space also dismisses
the delete button must have blue ring focus, but without the blue ring
d
blegh
i think we need focus rings here
b
that would have made me be more careful
d
i mean, just practically we need them across the board, i think?
āž• 1
b
when the modal came up, I froze for a sec and thought, wait what do I do here
cause of the lack of focus rings
d
totally
i'm leaning towards "actions that do a database write should be 
cmd enter
to confirm, never `enter`"
this i think is the case for posting a comment, but also i think it should be the case for confirming a red danger modal
there's other work around showing you actual keyboard hints, options include: ā€¢ always put the shortcut hint in the button ā€¢ put it on mouse over ā€¢ OR preferences around always having it in the button ā€¢ hold the 
cmd
key down and see the entire page's shortcuts ā€¢ ????
some are discoverable in the kb shortcut help popup, but AFAIK none of the contextual ones are ever displayed to the user at the time of the UI showing
l
David Balatero - changed status to Canceled for GT-8852 Users can easily delete their comments on accident via keyboard shortcuts
d
whoops, sorry about that churn, was playing with a Linear option.
anyways i have it filed, will chat more with another eng today if i can grab them
b
Cmd-Enter for the win, yes
That's a pretty great and established pattern that's already in my fingers šŸ˜„
Thanks for all the thought that's gone into this already.
Open in Slack
PreviousNext
Powered by