This message was deleted.
# feature-requests
s
This message was deleted.
g
Are these blue bars in the Graphite diff what you’re referring to?
j
I believe we've only implemented this for some languages, seems like we need to add GQL — cc @Ziyao Wei
b
Ah, that would explain it
z
Thanks for the feedback, will look into if!
To be clear this is for .graphql files? Or do you also see it missing in other places
b
I see it as missing in TypeScript and TSX files as well.
Compared to Github:
z
Ah this could be a different in our UI - if the header is identical to the previous chunk, i.e., it is in the same definition, then we don’t show it twice - maybe that’s what’s happening here? TypeScript should definitely work FWIW - so if that’s not the case I’ll look into it!
b
@Ziyao Wei Nope, it’s not showing the header at all anywhere. And the contents of the header are within hidden lines.
Do you maybe have this behind a feature flag that hasn’t rolled out everywhere?
z
Huh, I don’t believe so - can you MD me the PR number? Thanks! Also cc: @kush for the rollout
k
hey @Bilal Quadri! you’re right — we did have a feature flag that was not fully rolled out, preventing you from seeing these context lines 🤦‍♂️ i’ve got that fixed now so you should be able to see them soon! sorry for the miscommunication here
separately, like ziyao said, our context lines work a bit differently (hopefully better!) from GitHub’s so we’d love to get your feedback on them! and definitely try out
Expand to definition
by clicking on the function header itself 😉
b
Does this only affect PRs submitted after you rolled out the feature flag? I’m still just seeing
X lines hidden
.
k
hmmm it should now be visible for all
javascript/typescript
,
python
,
java
and
go
files — mind sharing an example if you’re still not seeing them? and separately, we’re looking at adding support for more languages so please let us know which other ones you’d like to see!