This message was deleted.
# announcements
s
This message was deleted.
1
e
I can see mine ok, although they do not stack for some reason
y
oh I can see now, not sure why it failed though
p
I’m seeing the same behavior now. I had PRs listed just two minutes ago and now everything is empty
👀 1
n
Hi all, appreciate the flag here — I’m taking a look in now!
@eriel marimon and @Pranav Kunapuli do you mind sharing your GitHub usernames here?
e
dibusan
👍 1
n
And just to double check, @eriel marimon you submitted those PRs as a stack with the graphite-cli right?
1
p
pranav-kunapuli
Btw it’s back up and running ofr me
👍 1
n
Hmm interesting! @Yu-Hsin Chou and @Pranav Kunapuli keep pinging us if the problem recurs — I don’t see anything obvious in our logs but we’ve had some light DB instability this morning so it could be as a result of that.
👌 1
e
Correct @Nicholas Yan. I see my PRs but they are not stack
👍 1
n
Cool, @eriel marimon taking a look in now!
🙏 1
And just to make sure I’m reading this right — is it that the stack goes 45 => 46 => 47 => 48 => 49?
e
yes 45 to 49
👍 1
n
Hmm, @eriel marimon I don’t see anything interesting in our code or logs here. If you try re-submitting those PRs from the Graphite CLI with a stack submit, does it heal the stack? (Stack submit is designed to be eventually consistent here so fingers crossed.)
e
Ive tried multiple times, still the same. Could you explain briefly how a PR is related to a stack in the implementation ? That relationship is just not being created. cc: @Nicholas Yan
😢 1
n
Yup, when you stack submit a PR: • we find other PRs with a head branch that is equal to the base branch of the PR • we link it in a stack There is one caveat where if you rebase a PR onto trunk and its parent PR is merged, we consider this part of the normal merging flow and don’t adjust the stack (a common user request). This shouldn’t apply here, however (and I just list it for completeness).
e
I just re submitted with the --always flag. Could you please confirm that this is indeed an issue, even if we don’t know how it is happening yet. I just want to rule out that I am misusing the tool.
we find other PRs with a head branch that is equal to the base branch of the PR
How is the head branch of each PR computed ? Im assuming it is some sort of recursive find process, find parent if not root -> repeat
If that is the case, why is it stopping on the parent PR? For example branch for PR #47 finds its parent, branch for PR #46 and stops the search right there, even though there is a branch for PR #45 which is the first child of main.
PR created by my teammate looks fine, it creates the relationship between the 4th branch in the stack and main.
🤔 1
n
Hi @eriel marimon, taking a look at those screenshots it looks like you’re using the tool correctly and there’s some funkiness on our end.
How is the head branch of each PR computed ? Im assuming it is some sort of recursive find process, find parent if not root -> repeat
Right; we hit the GitHub API to find the other PR(s) that have said base branch as their head branch and repeat that calculation down the stack.
If that is the case, why is it stopping on the parent PR? For example branch for PR #47 finds its parent, branch for PR #46 and stops the search right there, even though there is a branch for PR #45 which is the first child of main
You’re right that this is the buggy behavior — once we figure this out we’ll know what’s going on here 🙂
❤️ 2
j
I ran into this same thing (PRs not stacking on the UI) and it had to do with the remote repo name changing while my local was on the old repo name. After I ran
git remote set-url origin {new-url}
and
gt ss --always
the stack showed up! @eriel marimon it seems like your repo name may have changed from
ppfinder
to
map_athlete
?
🙌 1
🎉 1
e
Thanks a million @Jay!! This is it, all solved now. @Nicholas Yan it is now solved for me but should still be worked on Graphite’s end. A short term solution would be to print a warning to the user when the remote (configured locally) name or location differs from the one on github. Longer therm this shouldn’t even be an issues, should be handle transparently like github does, they simply create a mapping of the old remote name to the new one.
👍 2
n
Ah, incredible find @Jay! And yup, appreciate the feedback @eriel marimon; I would also love for this to just work on the Graphite side. (cc @Jacob Gold)
🙌 1