This message was deleted.
# bug-reportss
Slackbot
06/01/2023, 6:48 PMThis message was deleted.
a
Aryaman
06/01/2023, 6:51 PMCan you DM me the expected behavior for a given PR?
✅ 1
Aryaman
06/01/2023, 6:51 PMWith PR org/repo/number
e
Eddie Dugan
06/01/2023, 6:53 PMuniswap/interface/pull/6675
this repo has one approval but requires 2 approvals to merge, and i can't get the PR to appear in either my "approved" or "waiting for reviewers" sections with the following defs
Eddie Dugan
06/01/2023, 6:53 PM@Aryaman is this enough info? appreciate the response!
a
Aryaman
06/01/2023, 6:55 PMThanks, will take a quick look now to see if anything is off and a deeper look a bit later!
Aryaman
06/01/2023, 6:57 PMThis should be in "Waiting for reviewers" I think.
e
Eddie Dugan
06/01/2023, 6:58 PMi agree
a
Aryaman
06/01/2023, 7:00 PMDo you mind if I reset your filters to defaults?
e
Eddie Dugan
06/01/2023, 7:00 PMgo for it !
Eddie Dugan
06/01/2023, 7:00 PMi'm a 1-day-old user so i don't have much personalized
a
Aryaman
06/01/2023, 7:01 PMThat is concerning
Aryaman
06/01/2023, 7:01 PMSo let me look at why this happened
Aryaman
06/01/2023, 7:05 PMDo you guys use codeowners?
e
Eddie Dugan
06/01/2023, 7:07 PMoh shoot i just merged it
Eddie Dugan
06/01/2023, 7:07 PMwait that was dumb
a
Aryaman
06/01/2023, 7:09 PMAh no worries, let me know if you see this again!
e
Eddie Dugan
06/05/2023, 8:53 PM@Aryaman i have some PRs with this behavior again, would you mind taking another look?
as an example, this one has only 1 of the 2 required approvals and it's being counted in my "approved" count but doesn't actually appear in that section
Eddie Dugan
06/05/2023, 8:55 PMwe do have a CODEOWNERS file, but that's not included in the requirements for merging a PR to the
maina
Aryaman
06/05/2023, 9:18 PMCan you leave one or two of them unchanged?
✅ 1
Aryaman
06/05/2023, 9:18 PMIt will help debug
✅ 1
e
Eddie Dugan
06/05/2023, 9:26 PMtyvm
Eddie Dugan
06/05/2023, 9:27 PMactually i can't control my teammates but there are a few here so hopefully they don't all get approved
Eddie Dugan
06/05/2023, 9:27 PM(first time i've ever said that)
😆 1
a
Aryaman
06/05/2023, 9:28 PMIt's really strange, the DB state I see shouldn't put them in approved state
Aryaman
06/05/2023, 9:28 PMSo super confused
Aryaman
06/05/2023, 9:37 PM... looks like there were missing parentheses in the sql
Aryaman
06/05/2023, 9:37 PMFixing now, thanks for reporting!
e
Eddie Dugan
06/06/2023, 5:27 PMseems like it's working 🤝 thanks ~!!