This message was deleted.
# bug-reports
s
This message was deleted.
e
Oh interesting, it seems that the comment got submitted, but is now referencing a different line. On top of that, the comment starts with
[RE: lines 47 to 47]
which is where I actually placed the comment in the graphite UI.
x
@David Balatero for vis who has been cataloging a few bugs to fix in our commenting experience.
d
@Edo Rivai can you share the steps you took, so we can attempt to reproduce it?
e
Yeah it's a bit from memory, but I think it was this: 1. triple dot menu top-right on file =>
Show all lines
2. scroll up to a line that wasn't touched in the PR 3. add comment 4. observe that the comment "disappears" in graphite UI 5. observe that comment appears on other line in github UI
x
@Edo Rivai The comment shouldn’t disappear when you’re on Graphite (that sounds like a bug). As for the placement of the comment on GitHub: GitHub does not allow for commenting on unchanged lines. Graphite enables you to comment on unchanged lines and renders your comments on in the right place if you’re viewing the PR on app.graphite.dev however, if you’re viewing it on GitHub, you will see the comment pinned to the closest commentable line with the actual lines mentioned in the comment.
e
Okay, honestly I might misremember, this is all from memory. Maybe I just double checked github, and was confused that the comment was somewhere else.