This message was deleted.

if you’re interested in Graphite notifications in Slack, join us in #notifications-beta!

@kush I'm already in the beta, but my feature request isn't about notifications, it is about redirecting any graphite PR link to its corresponding GitHub link

ah, got it — is there any particular reason that you want to be redirected to github?

I am usually more comfortable with reviewing PRs on Github (matter of habit, I guess) and Graphite uses graphite.dev hyperlinks in the CLI and in the notifications, which makes me unable to directly go to Github (I need to manually go to the PR)

makes sense! we’d love to hear about what we can do to support your review workflow with Graphite 🙂

I think I was in the same boat as Youssef for awhile (I’ve been trying to use the Graphite dashboard more this week for reviews to get used to it) I took a few minutes to compare the GitHub Review page and the Graphite Review page, and I think for me, the discomfort mainly boils down to familiarity and colors? The Graphite review page feels (emphasis on personal feelings) more busy because the boxes for each file stands out more, the general info has lots of boxes, and there’s the additional description box. So when you land on the page it feels more overwhelming? (Though part of this is also I think being used to GitHub’s design and needing time to get used to the Graphite design). TL;DR: For me, the discomfort is a me thing, not a Graphite thing. Though I think I would like the design to move towards a smoother, less busy style (obligatory caveat; i’m not a real designer i have no design skills 😂 )

thanks for the feedback! we’re actively working on revamping the review experience and this is really helpful (cc @Xiulung Choy, our design team 😉) also, could you expand on what we can do to make the colors more familiar/comfortable?

Hmmmmm I think it’s ok for the colors to be different? My hypothesis is that there’s more cognitive load because all of the boxes standout, so there’s not one place that my eyes are drawn to (too many competing pieces of information). While GitHub’s Files changed section, for example, basically everything blends into the background except the lines that were changed. The diff itself is also slightly simpler? For example, there’s extra highlights in the Graphite review page than the GitHub review page (see screenshots). In the examples I attached, the extra green bits on top of the whole chunk seem extraneous? I think GitHub usually only includes those if the line is basically the same except to highlight a one word change. TL;DR: there’s lots of things competing for my attention on the graphite review page which makes it harder to focus on the code itself (at least I think this is what it is)

that’s really useful context, thank you! cc @Ziyao Wei, who’s currently thinking about ways to uplevel diff presentation!

I agree on Leslie's feedback, I am able to focus more on the code and diff in Github, also, the vibrant colors on Github helps in grabbing attention to diffs In addition to that, Graphite isn't very smooth on big PRs, the scrolling is a bit laggy and sluggish, so it is a big discouraging to use. One more, the description section is reaaaaaally wide, it is much easier to read PR descriptions on Github because the description section is centered and is smaller. Also, the gray text makes it really hard to focus on reading descriptions. Adding to that is that my eyes are more used to Github (naturally), so I also find myself going to Github for reviewing PRs.

we hear you! passing all of this along 🙂